Skip to content

Commit

Permalink
deps: V8: cherry-pick 9040405 from upstream
Browse files Browse the repository at this point in the history
Original commit message:

  s390x: fix high 32-bit word corruption issue

  R=joransiu@ca.ibm.com

  Change-Id: I9a2cf0f3e4a33dc4b86c83acfefcd27968bbcdb4
  Reviewed-on: https://chromium-review.googlesource.com/1176424
  Reviewed-by: Joran Siu <joransiu@ca.ibm.com>
  Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
  Cr-Commit-Position: refs/heads/master@{#55143}

Refs: v8/v8@ca95cd9

PR-URL: #22375
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
  • Loading branch information
Junliang Yan authored and BethGriggs committed Aug 23, 2018
1 parent 01e2eba commit 5294919
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 7 deletions.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 6
#define V8_MINOR_VERSION 2
#define V8_BUILD_NUMBER 414
#define V8_PATCH_LEVEL 65
#define V8_PATCH_LEVEL 66

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
12 changes: 6 additions & 6 deletions deps/v8/src/compiler/s390/instruction-selector-s390.cc
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,12 @@ ArchOpcode SelectLoadOpcode(Node* node) {
/* Float unary op*/ \
V(BitcastFloat32ToInt32) \
/* V(TruncateFloat64ToWord32) */ \
/* V(RoundFloat64ToInt32) */ \
/* V(TruncateFloat32ToInt32) */ \
/* V(TruncateFloat32ToUint32) */ \
/* V(TruncateFloat64ToUint32) */ \
/* V(ChangeFloat64ToInt32) */ \
/* V(ChangeFloat64ToUint32) */ \
V(RoundFloat64ToInt32) \
V(TruncateFloat32ToInt32) \
V(TruncateFloat32ToUint32) \
V(TruncateFloat64ToUint32) \
V(ChangeFloat64ToInt32) \
V(ChangeFloat64ToUint32) \
/* Word32 unary op */ \
V(Word32Clz) \
V(Word32Popcnt) \
Expand Down
12 changes: 12 additions & 0 deletions deps/v8/src/s390/macro-assembler-s390.cc
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,9 @@ void TurboAssembler::ConvertDoubleToInt32(const Register dst,
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(dst, Operand::Zero());
#endif
cfdbr(m, dst, double_input);
}

Expand All @@ -728,6 +731,9 @@ void TurboAssembler::ConvertFloat32ToInt32(const Register result,
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(result, Operand::Zero());
#endif
cfebr(m, result, double_input);
}

Expand All @@ -752,6 +758,9 @@ void TurboAssembler::ConvertFloat32ToUnsignedInt32(
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(result, Operand::Zero());
#endif
clfebr(m, Condition(0), result, double_input);
}

Expand Down Expand Up @@ -824,6 +833,9 @@ void TurboAssembler::ConvertDoubleToUnsignedInt32(
UNIMPLEMENTED();
break;
}
#ifdef V8_TARGET_ARCH_S390X
lghi(dst, Operand::Zero());
#endif
clfdbr(m, Condition(0), dst, double_input);
}

Expand Down

0 comments on commit 5294919

Please sign in to comment.