internal: add custom dir support for heapsnapshot-signal

nodejs · May 4, 2023 · 577ffbd · 577ffbd
1 parent 9e5e2f1
commit 577ffbd
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/internal/process/pre_execution.js b/lib/internal/process/pre_execution.js
@@ -8,6 +8,7 @@ const {
   ObjectGetOwnPropertyDescriptor,
   SafeMap,
   StringPrototypeStartsWith,
+  DateNow,
   globalThis,
 } = primordials;
 
@@ -365,6 +366,7 @@ function initializeReportSignalHandlers() {
 
 function initializeHeapSnapshotSignalHandlers() {
   const signal = getOptionValue('--heapsnapshot-signal');
+  const diagnosticDir = getOptionValue('--diagnostic-dir');
 
   if (!signal)
     return;
@@ -373,7 +375,8 @@ function initializeHeapSnapshotSignalHandlers() {
   const { writeHeapSnapshot } = require('v8');
 
   function doWriteHeapSnapshot() {
-    writeHeapSnapshot();
+    const heapSnapshotFilename = getHeapSnapshotFilename(diagnosticDir);
+    writeHeapSnapshot(heapSnapshotFilename);
   }
   process.on(signal, doWriteHeapSnapshot);
 
@@ -650,6 +653,11 @@ function markBootstrapComplete() {
   internalBinding('performance').markBootstrapComplete();
 }
 
+function getHeapSnapshotFilename(diagnosticDir) {
+  if (!diagnosticDir) return undefined;
+  return `${diagnosticDir}/Heap.${DateNow()}.heapsnapshot`;
+}
+
 module.exports = {
   setupUserModules,
   prepareMainThreadExecution,