Skip to content

Commit

Permalink
src: remove unneeded ABORT after CHECK
Browse files Browse the repository at this point in the history
CHECK includes node::Abort(), so that's unneeded to call ABORT after
CHECK.

PR-URL: #8593
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
yorkie authored and Fishrock123 committed Oct 11, 2016
1 parent 43d6212 commit 5ebce30
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions src/cares_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,6 @@ static void GetAddrInfo(const FunctionCallbackInfo<Value>& args) {
break;
default:
CHECK(0 && "bad address family");
ABORT();
}

GetAddrInfoReqWrap* req_wrap = new GetAddrInfoReqWrap(env, req_wrap_obj);
Expand Down Expand Up @@ -1261,7 +1260,6 @@ static void SetServers(const FunctionCallbackInfo<Value>& args) {
break;
default:
CHECK(0 && "Bad address family.");
ABORT();
}

if (err)
Expand Down
1 change: 0 additions & 1 deletion src/fs_event_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ void FSEventWrap::OnEvent(uv_fs_event_t* handle, const char* filename,
event_string = env->change_string();
} else {
CHECK(0 && "bad fs events flag");
ABORT();
}

Local<Value> argv[] = {
Expand Down
1 change: 0 additions & 1 deletion src/node_crypto_bio.cc
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ long NodeBIO::Ctrl(BIO* bio, int cmd, long num, // NOLINT(runtime/int)
break;
case BIO_C_SET_BUF_MEM:
CHECK(0 && "Can't use SET_BUF_MEM_PTR with NodeBIO");
ABORT();
break;
case BIO_C_GET_BUF_MEM_PTR:
CHECK(0 && "Can't use GET_BUF_MEM_PTR with NodeBIO");
Expand Down

0 comments on commit 5ebce30

Please sign in to comment.