-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: move test-crypto-engine to addon
Fixes: #41633 Fixes: #40958 - move test-crypto-engine so that dummy engine is only built if tests are run Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41830 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
- Loading branch information
Showing
7 changed files
with
143 additions
and
111 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
{ | ||
'targets': [ | ||
{ | ||
'target_name': 'testsetengine', | ||
'type': 'none', | ||
'includes': ['../common.gypi'], | ||
'conditions': [ | ||
['(OS=="mac" or OS=="linux") and ' | ||
'node_use_openssl=="true" and ' | ||
'node_shared=="false" and ' | ||
'node_shared_openssl=="false"', { | ||
'type': 'shared_library', | ||
'sources': [ 'testsetengine.cc' ], | ||
'product_extension': 'engine', | ||
'include_dirs': ['../../../deps/openssl/openssl/include'], | ||
'conditions': [ | ||
['OS=="mac"', { | ||
'xcode_settings': { | ||
'OTHER_CFLAGS': ['-Wno-deprecated-declarations'], | ||
}, | ||
'link_settings': { | ||
'libraries': [ | ||
'../../../../out/<(PRODUCT_DIR)/<(openssl_product)' | ||
] | ||
}, | ||
}], | ||
['OS=="linux"', { | ||
'cflags': [ | ||
'-Wno-deprecated-declarations', | ||
], | ||
}], | ||
], | ||
}], | ||
], | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
'use strict'; | ||
const common = require('../../common'); | ||
|
||
// This tests crypto.setEngine(). | ||
|
||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
|
||
const assert = require('assert'); | ||
const crypto = require('crypto'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
|
||
|
||
assert.throws(() => crypto.setEngine(true), /ERR_INVALID_ARG_TYPE/); | ||
assert.throws(() => crypto.setEngine('/path/to/engine', 'notANumber'), | ||
/ERR_INVALID_ARG_TYPE/); | ||
|
||
{ | ||
const invalidEngineName = 'xxx'; | ||
assert.throws(() => crypto.setEngine(invalidEngineName), | ||
/ERR_CRYPTO_ENGINE_UNKNOWN/); | ||
assert.throws(() => crypto.setEngine(invalidEngineName, | ||
crypto.constants.ENGINE_METHOD_RSA), | ||
/ERR_CRYPTO_ENGINE_UNKNOWN/); | ||
} | ||
|
||
crypto.setEngine('dynamic'); | ||
crypto.setEngine('dynamic'); | ||
|
||
crypto.setEngine('dynamic', crypto.constants.ENGINE_METHOD_RSA); | ||
crypto.setEngine('dynamic', crypto.constants.ENGINE_METHOD_RSA); | ||
|
||
const engine = path.join(__dirname, | ||
`/build/${common.buildType}/testsetengine.engine`); | ||
|
||
if (!fs.existsSync(engine)) | ||
common.skip('no engine'); | ||
|
||
{ | ||
const engineId = path.parse(engine).name; | ||
const execDir = path.parse(engine).dir; | ||
|
||
crypto.setEngine(engine); | ||
// OpenSSL 3.0.1 and 1.1.1m now throw errors if an engine is loaded again | ||
// with a duplicate absolute path. | ||
// TODO(richardlau): figure out why this fails on macOS but not Linux. | ||
// crypto.setEngine(engine); | ||
|
||
// crypto.setEngine(engine, crypto.constants.ENGINE_METHOD_RSA); | ||
// crypto.setEngine(engine, crypto.constants.ENGINE_METHOD_RSA); | ||
|
||
process.env.OPENSSL_ENGINES = execDir; | ||
|
||
crypto.setEngine(engineId); | ||
crypto.setEngine(engineId); | ||
|
||
crypto.setEngine(engineId, crypto.constants.ENGINE_METHOD_RSA); | ||
crypto.setEngine(engineId, crypto.constants.ENGINE_METHOD_RSA); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
#include <openssl/engine.h> | ||
|
||
#ifndef ENGINE_CMD_BASE | ||
# error did not get engine.h | ||
#endif | ||
|
||
#define TEST_ENGINE_ID "testsetengine" | ||
#define TEST_ENGINE_NAME "dummy test engine" | ||
|
||
#ifdef _WIN32 | ||
# define DEFAULT_VISIBILITY __declspec(dllexport) | ||
#else | ||
# define DEFAULT_VISIBILITY __attribute__((visibility("default"))) | ||
#endif | ||
|
||
namespace { | ||
|
||
int EngineInit(ENGINE* engine) { | ||
return 1; | ||
} | ||
|
||
int EngineFinish(ENGINE* engine) { | ||
return 1; | ||
} | ||
|
||
int EngineDestroy(ENGINE* engine) { | ||
return 1; | ||
} | ||
|
||
int bind_fn(ENGINE* engine, const char* id) { | ||
ENGINE_set_id(engine, TEST_ENGINE_ID); | ||
ENGINE_set_name(engine, TEST_ENGINE_NAME); | ||
ENGINE_set_init_function(engine, EngineInit); | ||
ENGINE_set_finish_function(engine, EngineFinish); | ||
ENGINE_set_destroy_function(engine, EngineDestroy); | ||
return 1; | ||
} | ||
|
||
extern "C" { | ||
DEFAULT_VISIBILITY IMPLEMENT_DYNAMIC_CHECK_FN(); | ||
DEFAULT_VISIBILITY IMPLEMENT_DYNAMIC_BIND_FN(bind_fn); | ||
} | ||
|
||
} // anonymous namespace |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters