-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
child_process: measure buffer length in bytes
This change fixes a known issue where `maxBuffer` limits by characters rather than bytes. Benchmark added to confirm no performance regression occurs with this change. PR-URL: #6764 Fixes: #1901 Reviewed-By: Brian White <mscdex@mscdex.net>
- Loading branch information
Showing
5 changed files
with
96 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
'use strict'; | ||
const common = require('../common.js'); | ||
const bench = common.createBenchmark(main, { | ||
len: [64, 256, 1024, 4096, 32768], | ||
dur: [5] | ||
}); | ||
|
||
const exec = require('child_process').exec; | ||
function main(conf) { | ||
bench.start(); | ||
|
||
const dur = +conf.dur; | ||
const len = +conf.len; | ||
|
||
const msg = `"${'.'.repeat(len)}"`; | ||
msg.match(/./); | ||
const options = {'stdio': ['ignore', 'pipe', 'ignore']}; | ||
// NOTE: Command below assumes bash shell. | ||
const child = exec(`while\n echo ${msg}\ndo :; done\n`, options); | ||
|
||
var bytes = 0; | ||
child.stdout.on('data', function(msg) { | ||
bytes += msg.length; | ||
}); | ||
|
||
setTimeout(function() { | ||
child.kill(); | ||
bench.end(bytes); | ||
}, dur * 1000); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const cp = require('child_process'); | ||
const unicode = '中文测试'; // Length = 4, Byte length = 13 | ||
|
||
if (process.argv[2] === 'child') { | ||
console.error(unicode); | ||
} else { | ||
const cmd = `${process.execPath} ${__filename} child`; | ||
|
||
cp.exec(cmd, {maxBuffer: 10}, common.mustCall((err, stdout, stderr) => { | ||
assert.strictEqual(err.message, 'stderr maxBuffer exceeded'); | ||
})); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters