async_wrap,http: handle init/destroy lifecycle within HttpParser

nodejs · Mar 22, 2016 · 64082db · 64082db
1 parent 206d243
commit 64082db
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/node_http_parser.cc b/src/node_http_parser.cc
@@ -150,7 +150,7 @@ struct StringPtr {
 class Parser : public AsyncWrap {
  public:
   Parser(Environment* env, Local<Object> wrap, enum http_parser_type type)
-      : AsyncWrap(env, wrap, AsyncWrap::PROVIDER_HTTPPARSER),
+      : AsyncWrap(env, wrap, AsyncWrap::PROVIDER_HTTPPARSER, nullptr, false),
         current_buffer_len_(0),
         current_buffer_data_(nullptr) {
     Wrap(object(), this);
@@ -457,6 +457,7 @@ class Parser : public AsyncWrap {
     // Should always be called from the same context.
     CHECK_EQ(env, parser->env());
     parser->Init(type);
+    parser->InitAsyncWrap(env, args.This(), AsyncWrap::PROVIDER_HTTPPARSER);
   }
 
 
@@ -488,6 +489,7 @@ class Parser : public AsyncWrap {
 
   static void Unconsume(const FunctionCallbackInfo<Value>& args) {
     Parser* parser = Unwrap<Parser>(args.Holder());
+    parser->DestroyAsyncWrap();
 
     // Already unconsumed
     if (parser->prev_alloc_cb_.is_empty())