Skip to content

Commit

Permalink
build: configure return exit status from gyp
Browse files Browse the repository at this point in the history
Previously, 'configure' would not return an exit status
if gyp blows up. This can be tested via:

    date >> node.gyp ; ./configure && echo A-OK

You will get "A-OK" even though gyp had failed.

Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
  • Loading branch information
srl295 authored and Julien Gilli committed Dec 15, 2014
1 parent 0603c83 commit 69b122a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure
Original file line number Diff line number Diff line change
Expand Up @@ -730,4 +730,4 @@ else:

gyp_args += args

subprocess.call(gyp_args)
sys.exit(subprocess.call(gyp_args))

0 comments on commit 69b122a

Please sign in to comment.