Skip to content

Commit

Permalink
test: use spread instead of object.assign
Browse files Browse the repository at this point in the history
PR-URL: #30412
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
19shubham11 authored and targos committed Dec 1, 2019
1 parent b22a946 commit 6c7e491
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/parallel/test-child-process-fork-args.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const expectedEnv = { foo: 'bar' };

argsLists.forEach((args) => {
const cp = fork(fixtures.path('child-process-echo-options.js'), args, {
env: Object.assign({}, process.env, expectedEnv)
env: { ...process.env, ...expectedEnv }
});

cp.on(
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-child-process-fork-exec-path.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ assert.strictEqual(fs.existsSync(copyPath), false);
fs.copyFileSync(nodePath, copyPath, fs.constants.COPYFILE_FICLONE);
fs.chmodSync(copyPath, '0755');

const envCopy = Object.assign({}, process.env, { 'FORK': 'true' });
const envCopy = { ...process.env, FORK: 'true' };
const child = fork(__filename, { execPath: copyPath, env: envCopy });
child.on('message', common.mustCall(function(recv) {
assert.deepStrictEqual(recv, msg);
Expand Down

0 comments on commit 6c7e491

Please sign in to comment.