repl: refactor to avoid unsafe array iteration

PR-URL: #37345 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Feb 16, 2021 · 6d53e79 · 6d53e79
1 parent 799b2d5
commit 6d53e79
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/lib/internal/repl/await.js b/lib/internal/repl/await.js
@@ -2,6 +2,7 @@
 
 const {
   ArrayFrom,
+  ArrayPrototypeForEach,
   ArrayPrototypeJoin,
   ArrayPrototypePop,
   ArrayPrototypePush,
@@ -61,10 +62,10 @@ const visitorsWithoutAncestors = {
         state.replace(node.start, node.start + node.kind.length, 'void (');
       }
 
-      for (const decl of node.declarations) {
+      ArrayPrototypeForEach(node.declarations, (decl) => {
         state.prepend(decl, '(');
         state.append(decl, decl.init ? ')' : '=undefined)');
-      }
+      });
 
       if (node.declarations.length !== 1) {
         state.append(node.declarations[node.declarations.length - 1], ')');

diff --git a/lib/internal/repl/utils.js b/lib/internal/repl/utils.js
@@ -103,6 +103,10 @@ function isRecoverableError(e, code) {
       staticClassFeatures,
       (Parser) => {
         return class extends Parser {
+          // eslint-disable-next-line no-useless-constructor
+          constructor(options, input, startPos) {
+            super(options, input, startPos);
+          }
           nextToken() {
             super.nextToken();
             if (this.type === tt.eof)

diff --git a/lib/repl.js b/lib/repl.js
@@ -62,7 +62,7 @@ const {
   Boolean,
   Error,
   FunctionPrototypeBind,
-  MathMax,
+  MathMaxApply,
   NumberIsNaN,
   NumberParseFloat,
   ObjectAssign,
@@ -1647,8 +1647,8 @@ function defineDefaultCommands(repl) {
     help: 'Print this help message',
     action: function() {
       const names = ArrayPrototypeSort(ObjectKeys(this.commands));
-      const longestNameLength = MathMax(
-        ...ArrayPrototypeMap(names, (name) => name.length)
+      const longestNameLength = MathMaxApply(
+        ArrayPrototypeMap(names, (name) => name.length)
       );
       ArrayPrototypeForEach(names, (name) => {
         const cmd = this.commands[name];