-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is a partial revert of 15157c3. This change lead to a regression that broke require() in the CLI REPL, as imported files were evaluated in a different context. Refs: #5703 Fixes: #7788 PR-URL: #7795 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
- Loading branch information
Showing
2 changed files
with
29 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const cp = require('child_process'); | ||
const path = require('path'); | ||
const child = cp.spawn(process.execPath, ['--interactive']); | ||
const fixture = path.join(common.fixturesDir, 'is-object.js').replace(/\\/g, | ||
'/'); | ||
let output = ''; | ||
|
||
child.stdout.setEncoding('utf8'); | ||
child.stdout.on('data', (data) => { | ||
output += data; | ||
}); | ||
|
||
child.on('exit', common.mustCall(() => { | ||
const results = output.split('\n').map((line) => { | ||
return line.replace(/\w*>\w*/, '').trim(); | ||
}); | ||
|
||
assert.deepStrictEqual(results, ['undefined', 'true', 'true', '']); | ||
})); | ||
|
||
child.stdin.write('const isObject = (obj) => obj.constructor === Object;\n'); | ||
child.stdin.write('isObject({});\n'); | ||
child.stdin.write(`require('${fixture}').isObject({});\n`); | ||
child.stdin.write('.exit'); | ||
child.stdin.end(); |