-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: fix test for inherited properties on vm
The known issue is fixed with #16293. The text needs to call `Object.hasOwnProperty(this)` instead of `this.hasOwnProperty()`, otherwise `this` is from the wrong context is used. Add a second test case taken verbatim from issue #5350 Fixes: #5350 Refs: #16293
- Loading branch information
Showing
2 changed files
with
38 additions
and
20 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
'use strict'; | ||
|
||
require('../common'); | ||
|
||
const vm = require('vm'); | ||
const assert = require('assert'); | ||
|
||
let base = { | ||
propBase: 1 | ||
}; | ||
|
||
let sandbox = Object.create(base, { | ||
propSandbox: { value: 3 } | ||
}); | ||
|
||
const context = vm.createContext(sandbox); | ||
|
||
let result = vm.runInContext('Object.hasOwnProperty(this, "propBase");', | ||
context); | ||
|
||
assert.strictEqual(result, false); | ||
|
||
// Ref: https://github.com/nodejs/node/issues/5350 | ||
base = Object.create(null); | ||
base.x = 1; | ||
base.y = 2; | ||
|
||
sandbox = Object.create(base); | ||
sandbox.z = 3; | ||
|
||
assert.deepStrictEqual(Object.keys(sandbox), ['z']); | ||
|
||
const code = 'x = 0; z = 4;'; | ||
result = vm.runInNewContext(code, sandbox); | ||
assert.strictEqual(result, 4); | ||
|
||
// Check that y is not an own property. | ||
assert.deepStrictEqual(Object.keys(sandbox), ['z', 'x']); |