Skip to content

Commit

Permalink
test: make CreateParams stack-allocated
Browse files Browse the repository at this point in the history
PR-URL: #17366
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
danbev authored and MylesBorins committed Dec 12, 2017
1 parent ca81d4b commit 78592a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/cctest/node_test_fixture.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ class NodeTestFixture : public ::testing::Test {
node::MultiIsolatePlatform* Platform() const { return platform_; }

protected:
v8::Isolate::CreateParams params_;
v8::Isolate* isolate_;

~NodeTestFixture() {
Expand All @@ -73,6 +72,7 @@ class NodeTestFixture : public ::testing::Test {
platform_ = new node::NodePlatform(8, nullptr);
v8::V8::InitializePlatform(platform_);
v8::V8::Initialize();
v8::Isolate::CreateParams params_;
params_.array_buffer_allocator = allocator_.get();
isolate_ = v8::Isolate::New(params_);
}
Expand Down

0 comments on commit 78592a3

Please sign in to comment.