Skip to content

Commit

Permalink
test: refactor async-hooks test-callback-error
Browse files Browse the repository at this point in the history
Two child processes have their logic in a switch statement and a third
uses an `if` statement to detect it. Move all three child process tasks
into switch statement.

PR-URL: #13554
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
  • Loading branch information
Trott authored and addaleax committed Jun 12, 2017
1 parent 00d2f7c commit 812e0b0
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions test/async-hooks/test-callback-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,14 @@ switch (process.argv[2]) {
async_hooks.triggerId());
async_hooks.emitBefore(async_hooks.currentId());
break;
}

if (process.execArgv.includes('--abort-on-uncaught-exception')) {
initHooks({
oninit: common.mustCall(() => { throw new Error('test_callback_abort'); })
}).enable();
case 'test_callback_abort':
initHooks({
oninit: common.mustCall(() => { throw new Error('test_callback_abort'); })
}).enable();

async_hooks.emitInit(async_hooks.currentId(), 'test_callback_abort',
async_hooks.triggerId());
async_hooks.emitInit(async_hooks.currentId(), 'test_callback_abort',
async_hooks.triggerId());
break;
}

const c1 = spawnSync(`${process.execPath}`, [__filename, 'test_init_callback']);
Expand Down

0 comments on commit 812e0b0

Please sign in to comment.