src: do not treat all paths ending with node_modules as such

Fixes: #51245 PR-URL: #51269 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
nodejs · Jan 2, 2024 · 864ecb0 · 864ecb0
1 parent f4f781d
commit 864ecb0
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/src/node_modules.cc b/src/node_modules.cc
@@ -363,7 +363,7 @@ void BindingData::GetPackageScopeConfig(
     return;
   }
 
-  std::string_view node_modules_package_path = "node_modules/package.json";
+  std::string_view node_modules_package_path = "/node_modules/package.json";
   auto error_context = ErrorContext();
   error_context.is_esm = true;
 

diff --git a/test/es-module/test-esm-resolve-type.mjs b/test/es-module/test-esm-resolve-type.mjs
@@ -38,6 +38,7 @@ try {
    * with the defaultResolver
    */
   [
+    [ '/es-modules/package-ends-node_modules/index.js', 'module' ],
     [ '/es-modules/package-type-module/index.js', 'module' ],
     [ '/es-modules/package-type-commonjs/index.js', 'commonjs' ],
     [ '/es-modules/package-without-type/index.js', 'commonjs' ],

diff --git a/test/fixtures/es-modules/package-ends-node_modules/index.js b/test/fixtures/es-modules/package-ends-node_modules/index.js
diff --git a/test/fixtures/es-modules/package-ends-node_modules/package.json b/test/fixtures/es-modules/package-ends-node_modules/package.json