Apply suggestions from code review

Co-authored-by: Jordan Harband <ljharb@gmail.com>
nodejs · Jul 4, 2020 · 8fe68f7 · 8fe68f7
1 parent 105b7f2
commit 8fe68f7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -40,8 +40,9 @@ const {
   RegExpPrototypeTest,
   SafeMap,
   SafeWeakMap,
-  Set,
+  SafeSet,
   String,
+  StringPrototypeIncludes,
   StringPrototypeIndexOf,
   StringPrototypeLastIndexOf,
   StringPrototypeMatch,
@@ -574,7 +575,7 @@ function resolveExportsTarget(baseUrl, target, subpath, mappingKey) {
         return fileURLToPath(resolved);
       } catch (err) {
         if (err.code === 'ERR_INVALID_FILE_URL_PATH' &&
-            err.message.includes('must not include encoded "/" characters')) {
+            StringPrototypeIncludes(err.message, 'must not include encoded "/" characters')) {
           throw new ERR_INVALID_MODULE_SPECIFIER(
             resolved.pathname, 'must not include encoded "/" characters',
             fileURLToPath(baseUrl));
@@ -990,7 +991,7 @@ Module._load = function(request, parent, isMain) {
 };
 
 // TODO: Use this set when resolving pkg#exports conditions.
-const cjsConditions = new Set(['require', 'node']);
+const cjsConditions = new SafeSet(['require', 'node']);
 Module._resolveFilename = function(request, parent, isMain, options) {
   if (NativeModule.canBeRequiredByUsers(request)) {
     return request;