test: favor strict equality in pummel net tests

Favor strict equality checks over loose equality checks in pummel/test-net-* tests. PR-URL: #8135 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Aug 19, 2016 · 8ff3d61 · 8ff3d61
1 parent a0971b7
commit 8ff3d61
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/test/pummel/test-net-connect-econnrefused.js b/test/pummel/test-net-connect-econnrefused.js
@@ -19,7 +19,7 @@ function pummel() {
     net.createConnection(common.PORT).on('error', function(err) {
       assert.equal(err.code, 'ECONNREFUSED');
       if (--pending > 0) return;
-      if (rounds == ROUNDS) return check();
+      if (rounds === ROUNDS) return check();
       rounds++;
       pummel();
     });

diff --git a/test/pummel/test-net-connect-memleak.js b/test/pummel/test-net-connect-memleak.js
@@ -17,7 +17,7 @@ var before = 0;
   before = process.memoryUsage().rss;
 
   net.createConnection(common.PORT, '127.0.0.1', function() {
-    assert(junk.length != 0);  // keep reference alive
+    assert.notStrictEqual(junk.length, 0);  // keep reference alive
     setTimeout(done, 10);
     global.gc();
   });

diff --git a/test/pummel/test-net-many-clients.js b/test/pummel/test-net-many-clients.js
@@ -69,7 +69,7 @@ server.listen(common.PORT, function() {
   var finished_clients = 0;
   for (var i = 0; i < concurrency; i++) {
     runClient(function() {
-      if (++finished_clients == concurrency) server.close();
+      if (++finished_clients === concurrency) server.close();
     });
   }
 });

diff --git a/test/pummel/test-net-timeout.js b/test/pummel/test-net-timeout.js
@@ -52,7 +52,7 @@ echo_server.listen(common.PORT, function() {
         client.write('hello\r\n');
       }, 500);
 
-      if (exchanges == 5) {
+      if (exchanges === 5) {
         console.log('wait for timeout - should come in ' + timeout + ' ms');
         starttime = new Date();
         console.dir(starttime);

diff --git a/test/pummel/test-net-timeout2.js b/test/pummel/test-net-timeout2.js
@@ -14,7 +14,7 @@ var server = net.createServer(function(socket) {
   var interval = setInterval(function() {
     counter++;
 
-    if (counter == seconds) {
+    if (counter === seconds) {
       clearInterval(interval);
       server.close();
       socket.destroy();