Skip to content

Commit

Permalink
test: use reserved .invalid TLD for invalid address in test
Browse files Browse the repository at this point in the history
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott authored and MylesBorins committed Nov 21, 2019
1 parent 92f766b commit 902c670
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/internet/test-dgram-send-cb-quelches-error.js
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ function callbackOnly(err) {
assert.ok(err);
socket.removeListener('error', onEvent);
socket.on('error', mustCall(onError));
socket.send(buffer, 0, buffer.length, 100, 'dne.example.com');
socket.send(buffer, 0, buffer.length, 100, 'dne.invalid');
}

function onEvent(err) {

0 comments on commit 902c670

Please sign in to comment.