Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.2.0 proposal #30547

Merged
merged 176 commits into from
Nov 21, 2019
Merged

v13.2.0 proposal #30547

merged 176 commits into from
Nov 21, 2019

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Nov 19, 2019

Notable Changes

  • addons:
    • Deprecate one- and two-argument AtExit(). Use the three-argument variant of AtExit() or AddEnvironmentCleanupHook() instead (Anna Henningsen) #30227
  • child_process,cluster:
    • The serialization option is added that allows child process IPC to use the V8 serialization API (to e.g., pass through data types like sets or maps) (Anna Henningsen) #30162
  • deps:
    • Update V8 to 7.9
    • Update npm to 6.13.1 (Ruy Adorno) #30271
  • embedder:
    • Exposes the ability to pass cli flags / options through an API as embedder (Shelley Vohr) #30466
    • Allow adding linked bindings to Environment (Anna Henningsen) #30274
  • esm:
    • Unflag --experimental-modules (Guy Bedford) #29866
  • stream:
    • Add writable.writableCorked property (Robert Nagy) #29012
  • worker:
    • Allow specifying resource limits (Anna Henningsen) #26628
  • v8:
    • The Serialization API is now stable (Anna Henningsen) #30234

Commits

  • [b76c13ec86] - assert: replace var with let in lib/assert.js (PerfectPan) #30261
  • [7f49816e8a] - benchmark: use let instead of var in async_hooks (dnlup) #30470
  • [0130d2b6e0] - benchmark: use let instead of var in assert (dnlup) #30450
  • [9cae205f4d] - buffer: change var to let (Vladislav Botvin) #30292
  • [b5198cd3b0] - (SEMVER-MINOR) build: reset embedder string to "-node.0" (Michaël Zasso) #30513
  • [f4f210adc1] - build: store cache on timed out builds on Travis (Richard Lau) #30469
  • [277e5fadf8] - (SEMVER-MINOR) build,tools: update V8 gypfiles for V8 7.9 (Michaël Zasso) #30020
  • [e51beef8d4] - (SEMVER-MINOR) child_process,cluster: allow using V8 serialization API (Anna Henningsen) #30162
  • [6bf0e40bad] - cluster: destruct primordials in lib/internal/cluster/worker.js (peze) #30246
  • [18ec8a84be] - (SEMVER-MINOR) crypto: add support for IEEE-P1363 DSA signatures (Tobias Nießen) #29292
  • [39d0a25ddd] - crypto: fix key requirements in asymmetric cipher (Tobias Nießen) #30249
  • [8c2e2ce6bf] - crypto: update root certificates (AshCripps) #30195
  • [4f282f52f0] - deps: patch V8 to 7.9.317.23 (Myles Borins) #30560
  • [9b71534d23] - deps: upgrade npm to 6.13.1 (claudiahdz) #30533
  • [f17c794faf] - (SEMVER-MINOR) deps: patch V8 to be API/ABI compatible with 7.8 (from 7.9) (Michaël Zasso) #30513
  • [5a1ad570ea] - deps: V8: cherry-pick a7dffcd767be (Christian Clauss) #30218
  • [2c6cf902b0] - (SEMVER-MINOR) deps: V8: cherry-pick 50031fae736f (Michaël Zasso) #30020
  • [1e5e8c3922] - deps: V8: cherry-pick e5dbc95 (Gabriel Schulhof) #30130
  • [9c356ba91c] - (SEMVER-MINOR) deps: V8: backport 5e755c6ee6d3 (Michaël Zasso) #30020
  • [fe99841c88] - (SEMVER-MINOR) deps: V8: backport 07ee86a5a28b (Michaël Zasso) #30020
  • [5131bbe477] - (SEMVER-MINOR) deps: V8: cherry-pick 777fa98 (Michaël Zasso) #30020
  • [824e8b6f9b] - (SEMVER-MINOR) deps: V8: cherry-pick 7228ef8 (Michaël Zasso) #30020
  • [4c7acc256a] - (SEMVER-MINOR) deps: V8: cherry-pick 6b0a953 (Michaël Zasso) #30020
  • [ebef1b2308] - (SEMVER-MINOR) deps: V8: cherry-pick bba5f1f (Michaël Zasso) #30020
  • [28ca44c724] - (SEMVER-MINOR) deps: V8: cherry-pick cfe9172 (Michaël Zasso) #30020
  • [ba4abfd198] - (SEMVER-MINOR) deps: V8: cherry-pick 3e82c8d (Michaël Zasso) #30020
  • [2abdcbbe5e] - (SEMVER-MINOR) deps: V8: cherry-pick f2d92ec (Michaël Zasso) #30020
  • [46383616e3] - (SEMVER-MINOR) deps: make v8.h compatible with VS2015 (Joao Reis) #30020
  • [5bc35732aa] - (SEMVER-MINOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #27375
  • [627a804627] - (SEMVER-MINOR) deps: V8: patch register-arm64.h (Refael Ackermann) #27375
  • [13e6b0b82a] - (SEMVER-MINOR) deps: update V8's postmortem script (Colin Ihrig) #30020
  • [a4a6565348] - (SEMVER-MINOR) deps: update V8's postmortem script (Colin Ihrig) #29694
  • [4182e3bad7] - (SEMVER-MINOR) deps: patch V8 to run on older XCode versions (Ujjwal Sharma) #29694
  • [6566c15157] - (SEMVER-MINOR) deps: V8: silence irrelevant warnings (Michaël Zasso) #26685
  • [6018db2ef9] - (SEMVER-MINOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #26685
  • [605cb9f0fc] - (SEMVER-MINOR) deps: update V8 to 7.9.317.22 (Michaël Zasso) #30513
  • [b82f63d9ca] - deps: update nghttp2 to 1.40.0 (gengjiawen) #30493
  • [401d2e9115] - deps: update npm to 6.13.0 (Ruy Adorno) #30271
  • [f8ee70c94d] - dgram: remove listeners on bind error (Anna Henningsen) #30210
  • [0433d7995a] - dgram: reset bind state before emitting error (Anna Henningsen) #30210
  • [0f8662d615] - dns: switch var to const/let (Dmitriy Kikinskiy) #30302
  • [ab887bd5f6] - doc: add mention for using promisify on class methods (Denys Otrishko) #30355
  • [9940116aba] - doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE (Denys Otrishko) #30371
  • [027bde563d] - doc: fix overriding of prefix option (Luigi Pinca) #30518
  • [b7757533bc] - doc: update http.md mention of socket (Jesse O'Connor) #30155
  • [7f664e454b] - doc: adds NO_COLOR to assert doc page (Shobhit Chittora) #30483
  • [fba2f9a3d6] - doc: document timed out Travis CI builds (Richard Lau) #30469
  • [c40e242b32] - doc: replace const / var with let (Duncan Healy) #30446
  • [a93345b7cd] - doc: update outdated commonjs compat info (Geoffrey Booth) #30512
  • [b590533253] - doc: esm: improve dual package hazard docs (Geoffrey Booth) #30345
  • [d631a0a3e4] - doc: update 8.x to 10.x in backporting guide (garygsc) #30481
  • [7e603bed52] - doc: createRequire can take import.meta.url directly (Geoffrey Booth) #30495
  • [e4a296ce8d] - doc: add entry to url.parse() changes metadata (Luigi Pinca) #30348
  • [64cf00b0b9] - doc: simplify text in pull-requests.md (Rich Trott) #30458
  • [1e2672012f] - doc: remove "multiple variants" from BUILDING.md (Rich Trott) #30366
  • [2d16a74ff9] - doc: remove "maintenance is supported by" text in BUILDING.md (Rich Trott) #30365
  • [c832565290] - doc: add lookup to http.request() options (Luigi Pinca) #30353
  • [b8afe57e85] - doc: fix up N-API doc (Michael Dawson) #30254
  • [b558d941bd] - doc: fix some recent doc nits (vsemozhetbyt) #30341
  • [1133981eac] - doc: add link to node-code-ide-configs in testing (Trivikram Kamat) #24012
  • [041f3a306e] - doc: update divergent specifier hazard guidance (Geoffrey Booth) #30051
  • [085af30361] - doc: include --experimental-resolve-self in manpage (Guy Bedford) #29978
  • [31a3b724f0] - doc: update GOVERNANCE.md (Rich Trott) #30259
  • [15a7032d44] - doc: move inactive Collaborators to emeriti (Rich Trott) #30243
  • [fabc489dba] - doc: update examples in writing-tests.md (garygsc) #30126
  • [1836eae7a6] - doc, console: remove non-existant methods from docs (Simon Schick) #30346
  • [7ad2e024dd] - doc,meta: allow Travis results for doc/comment changes (Rich Trott) #30330
  • [2deea28070] - doc,meta: remove wait period for npm pull requests (Rich Trott) #30329
  • [7e0f90e286] - domain: rename var to let and const (Maria Stogova) #30312
  • [c2c74fc93e] - encoding: make TextDecoder handle BOM correctly (Anna Henningsen) #30132
  • [f9eab48dd0] - esm: disable non-js exts outside package scopes (Guy Bedford) #30501
  • [3d8cdf191d] - esm: unflag --experimental-modules (Guy Bedford) #29866
  • [293e8a2384] - esm: exit the process with an error if loader has an issue (Michaël Zasso) #30219
  • [45fd44c6ec] - fs: change var to let (Nadya) #30318
  • [bb6f944607] - fs: add noop stub for FSWatcher.prototype.start (Lucas Holmquist) #30160
  • [4fe62c1620] - http: revise _http_server.js (telenord) #30279
  • [62e15a793a] - http: outgoing cork (Robert Nagy) #29053
  • [50f9476a44] - http: http_common rename var to let and const (telenord) #30288
  • [b8aceace95] - http: http_incoming rename var to let and const (telenord) #30285
  • [a37ade8648] - http: replace vars with lets and consts in lib/_http_agent.js (palmires) #30301
  • [e59cc8aad8] - http,async_hooks: keep resource object alive from socket (Anna Henningsen) #30196
  • [1b84175924] - http2: remove duplicated assertIsObject (Yongsheng Zhang) #30541
  • [666588143e] - http2: use custom BaseObject smart pointers (Anna Henningsen) #30374
  • [f25b00aaca] - (SEMVER-MINOR) https: add client support for TLS keylog events (Sam Roberts) #30053
  • [88da3af6f6] - https: change var to let in lib/https.js (galina.prokofeva) #30320
  • [f15a3b0281] - lib: replace var with let (David OLIVIER) #30381
  • [31a63ab1ec] - lib: replace var with let and const in readline.js (VinceOPS) #30377
  • [3eeeea419d] - lib: change var to let/const in internal/querystring.js (Artem Maksimov) #30286
  • [f10608655b] - lib: change var to let in internal/streams (Kyriakos Markakis) #30430
  • [3ce6e15844] - lib: replace var with let/const (Kenza Houmani) #30440
  • [d37d340472] - lib: change var to let in string_decoder (mkdorff) #30393
  • [9a1c16eda4] - lib: replaced var to let in lib/v8.js (Vadim Gorbachev) #30305
  • [3e4a6a5968] - lib: change var to let in lib/_stream_duplex.js (Ilia Safronov) #30297
  • [c7c566023f] - module: reduce circular dependency of internal/modules/cjs/loader (Joyee Cheung) #30349
  • [e98d89cef9] - module: conditional exports with flagged conditions (Guy Bedford) #29978
  • [caedcd9ef9] - module: fix for empty object in InternalModuleReadJSON (Guy Bedford) #30256
  • [66e1adf200] - net: destructure primordials (Guilherme Goncalves) #30447
  • [9230ffffd0] - net: replaced vars to lets and consts (alexahdp) #30287
  • [9248c8b960] - path: replace var with let in lib/path.js (peze) #30260
  • [e363f8e17f] - process: add coverage tests for sourceMapFromDataUrl method (Nolik) #30319
  • [7b4187413e] - process: make source map getter resistant against prototype tampering (Anna Henningsen) #30228
  • [183464a24d] - querystring: replace var with let/const (Raoul Jaeckel) #30429
  • [7188b9599d] - src: fix -Winconsistent-missing-override warning (Colin Ihrig) #30549
  • [966404fd24] - src: add file name to 'Module did not self-register' error (Jeremy Apthorp) #30125
  • [21dd6019ec] - (SEMVER-MINOR) src: expose ArrayBuffer version of Buffer::New() (Anna Henningsen) #30476
  • [2e43686c5a] - src: mark ArrayBuffers with free callbacks as untransferable (Anna Henningsen) #30475
  • [564c18e214] - src: remove HandleWrap instances from list once closed (Anna Henningsen) #30374
  • [4222f2400a] - src: remove keep alive option from SetImmediate() (Anna Henningsen) #30374
  • [940a2972b2] - src: use BaseObjectPtr for keeping channel alive in dns bindings (Anna Henningsen) #30374
  • [a2dbadc1ce] - src: introduce custom smart pointers for BaseObjects (Anna Henningsen) #30374
  • [1a92c88418] - src: migrate off ArrayBuffer::GetContents (Anna Henningsen) #30339
  • [0d5de1a20e] - (SEMVER-MINOR) src: remove custom tracking for SharedArrayBuffers (Anna Henningsen) #30020
  • [f0ff2ed9d5] - (SEMVER-MINOR) src: update v8abbr.h for V8 update (Colin Ihrig) #30020
  • [2c8276eda8] - (SEMVER-MINOR) src: expose ability to set options (Shelley Vohr) #30466
  • [592d51cb23] - src: enhance feature access CHECKs during bootstrap (Anna Henningsen) #30452
  • [d648c933b5] - src: lib/internal/timers.js var -> let/const (Nikolay Krashnikov) #30314
  • [70ad676023] - src: persist strings that are used multiple times in the environment (Vadim Gorbachev) #30321
  • [b744070d74] - (SEMVER-MINOR) src: allow adding linked bindings to Environment (Anna Henningsen) #30274
  • [058a8d5363] - src: do not use std::function for OnScopeLeave (Anna Henningsen) #30134
  • [906d279e69] - src: run RunBeforeExitCallbacks as part of EmitBeforeExit (Anna Henningsen) #30229
  • [66b3619b4e] - src: use unique_ptr for InitializeInspector() (Anna Henningsen) #30229
  • [db7deb6e7a] - src: make WaitForInspectorDisconnect an exit hook (Anna Henningsen) #30229
  • [cd233e3f16] - src: make EndStartedProfilers an exit hook (Anna Henningsen) #30229
  • [8234d04b56] - src: track no of active JS signal handlers (Anna Henningsen) #30229
  • [0072a8eddf] - src: remove AsyncScope and AsyncCallbackScope (Anna Henningsen) #30236
  • [e3371f0c93] - src: use callback scope for main script (Anna Henningsen) #30236
  • [cd6d6215cc] - (SEMVER-MINOR) src: deprecate two- and one-argument AtExit() (Anna Henningsen) #30227
  • [5f4535a97c] - src: make AtExit() callbacks run in reverse order (Anna Henningsen) #30230
  • [44968f0edc] - src: remove unimplemented method from node.h (Anna Henningsen) #30098
  • [4524c7ad36] - stream: replace var with let (daern91) #30379
  • [41720d78c9] - stream: add writableCorked to Duplex (Anna Henningsen) #29053
  • [7cbdac9a71] - stream: increase MAX_HWM (Robert Nagy) #29938
  • [c254d7469d] - (SEMVER-MINOR) stream: add writableCorked property (Robert Nagy) #29012
  • [cb9c64a6e0] - test: move test not requiring internet from internet to parallel (Rich Trott) #30545
  • [902c6702df] - test: use reserved .invalid TLD for invalid address in test (Rich Trott) #30545
  • [92f766bd83] - test: improve assertion message in internet dgram test (Rich Trott) #30545
  • [a5f25ecf07] - test: cover 'close' method in Dir class (Artem Maksimov) #30310
  • [45e57303f3] - test: add test for options validation of createServer (Yongsheng Zhang) #30541
  • [6be03981b2] - test: clean up http-set-trailers (Denys Otrishko) #30522
  • [2952c5d72b] - (SEMVER-MINOR) test: increase limit again for network space overhead test (Michaël Zasso) #30020
  • [4131b14011] - (SEMVER-MINOR) test: update test-postmortem-metadata.js (Colin Ihrig) #30020
  • [c464ede598] - test: handle undefined default_configuration (Shelley Vohr) #30465
  • [5ec550de02] - test: Change from var to const (Jure Stepisnik) #30431
  • [13bac0ac0f] - test: changed var to let in test-repl-editor (JL Phillips) #30443
  • [0d12e9cc29] - test: improve test-fs-open (Artem Maksimov) #30280
  • [89bc2526ab] - test: change var to let (nathias) #30444
  • [fa071efea4] - test: changed var to const in test (Kerry Mahne) #30434
  • [13a22432fc] - test: var to const in test-repl-multiline.js (SoulMonk) #30433
  • [109da52141] - test: deflake test-http-dump-req-when-res-ends.js (Luigi Pinca) #30360
  • [72bbd5cdb0] - test: change var to const in parallel/test-stream-transform-final* (Kenza Houmani) #30448
  • [cd82e4d9d8] - test: replace Object.assign with object spread (Grigoriy Levanov) #30306
  • [aec695eb6c] - test: fix Python unittests in ./test and ./tools (Christian Clauss) #30340
  • [ea0c1a67c5] - test: mark test-http-dump-req-when-res-ends as flaky on windows (AshCripps) #30316
  • [308f5e4710] - test: fix test-benchmark-cluster (Rich Trott) #30342
  • [bb0727a132] - test: do not run release-npm test without crypto (Michaël Zasso) #30265
  • [ab5bca379f] - test: remove AtExit() addon test (Anna Henningsen) #30275
  • [de68720908] - test: deflake test-tls-close-notify.js (Luigi Pinca) #30202
  • [8fe684961b] - Revert "test: test configure ninja" (Anna Henningsen) #30295
  • [0dedecc7e0] - test: test configure ninja (Patrick Housley) #30033
  • [01fa18c99c] - (SEMVER-MINOR) tls: cli option to enable TLS key logging to file (Sam Roberts) #30055
  • [5869f2bee7] - tls: change loop var to let (Xavier Redondo) #30445
  • [26a9bdfca3] - tls: replace var with let (Daniil Pletnev) #30308
  • [bad0b66580] - tls: replace var with let and const (Nolik) #30299
  • [ae5aa3ee83] - tls: refactor tls_wrap.cc (Artem Maksimov) #30303
  • [80b1717c0f] - tools: fix build at non-English windows (Rongjian Zhang) #30492
  • [642b0b883f] - tools: update tzdata to 2019c (Albert Wang) #30356
  • [3a44adebf8] - tools: pull xcode_emulation.py from node-gyp (Christian Clauss) #30272
  • [92fa4e0096] - tools: make doctool work if no internet available (Richard Lau) #30214
  • [0f9f18aabe] - tools: update certdata.txt (AshCripps) #30195
  • [dbdc3818e0] - tools: check-imports using utf-8 (Christian Clauss) #30220
  • [3b45f8fd9c] - url: replace var with let in lib/url.js (xefimx) #30281
  • [35dc84859f] - util: replace var with let (Susana Ferreira) #30439
  • [3727a6572b] - v8: mark serdes API as stable (Anna Henningsen) #30234
  • [9b11bdb001] - v8: inspect unserializable objects (Anna Henningsen) #30167
  • [2ec40c265a] - (SEMVER-MINOR) worker: allow specifying resource limits (Anna Henningsen) #26628

cclauss and others added 30 commits November 16, 2019 23:59
PR-URL: nodejs#30220
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This is the certdata.txt[0] from NSS 3.47, released on 2019-10-21.

This is the version of NSS that will ship in Firefox 71 on
2019-12-10.

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_47_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: nodejs#30195
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.

Certificates added:

Certificates removed:
- Certplus Class 2 Primary CA
- Deutsche Telekom Root CA 2

PR-URL: nodejs#30195
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Allow specifying resource limits for the JS engine instance created
as part of a Worker.

PR-URL: nodejs#26628
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This would otherwise sometimes just print relatively useless
information about the value in question, such as `[object Object]`.

PR-URL: nodejs#30167
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Do not accept the BOM if it comes from a different encoding, and
only discard the BOM after it has actually been read (including
when it is spread over multiple chunks in streaming mode).

Fixes: nodejs#25315

PR-URL: nodejs#30132
Reviewed-By: Gus Caplan <me@gus.host>
This function was not actually available during any part
of the Node 12 release line because it had been removed
earlier (likely accidentally).

Refs: nodejs#27220

PR-URL: nodejs#30098
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This makes the actual behaviour match the documented (and arguably
the correct) behaviour.

PR-URL: nodejs#30230
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Since this code runs during process and Worker shutdown, it should not
call user-provided code and thereby e.g. provide a way to break out of
`worker.terminate()`.

PR-URL: nodejs#30228
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Add an `serialization` option that allows child process IPC to
use the (typically more powerful) V8 serialization API.

Fixes: nodejs#10965

PR-URL: nodejs#30162
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
* Motivation: In a previous PR, nodejs#29905, I made this method a private
method since it had no value to the user.

There was discussion that maybe it should have been a runtime
deprecation first, but was ultimatley decided that for this
type of method, a noop stub was a better option.

This Adds back in the method, but as a noop stub, while also keeping
the real implementation private

PR-URL: nodejs#30160
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
`writing-tests.md` states to use arrow functions when appropriate.
This updates the examples to do that.

Further, this syncs the docs with what's found in
[`test/parallel/test-http-agent-null.js`](https://github.com/nodejs/node/blob/master/test/parallel/test-http-agent-null.js)

PR-URL: nodejs#30126
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: nodejs#29012
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Using `AtExit()` without an `Environment*` pointer or providing
an argument is almost always a sign of improperly relying on global
state and/or using `AtExit()` as an addon when the addon-targeting
`AddEnvironmentCleanupHook()` would be the better choice.

Deprecate those variants. This also updates the addon docs to
refer to `AddEnvironmentCleanupHook()` rather than `AtExit()`.

PR-URL: nodejs#30227
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This has been around for a long time, and the underlying V8 API has
become stable as well a while ago.

PR-URL: nodejs#30234
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Allow doctool to fallback to use local files if not building a release
build.

PR-URL: nodejs#30214
Fixes: nodejs#29918
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
- Updated the tooltest target to run unittest module
- Renamed test/tools/test-js2c.py to be discoverable by unittest module
- Added test class for `configure` shell script
- Added a test to ensure `configure` script exits with status code zero
when passed the `--ninja` flag

Closes: nodejs#29415

PR-URL: nodejs#30033
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Move a handful of inactive Collaborators to emeriti.

PR-URL: nodejs#30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#30272
Fixes: nodejs#30129
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
If `asyncReset()` is used to specify an alternative resource object
to mark a re-used socket in the HTTP Agent implementation,
store that object and keep it alive, because domains rely on GC tracking
for resource objects to manage their own lifetimes, and previously that
resource object might have been garbage-collected too early, leading to
crashes.

Fixes: nodejs#30122

PR-URL: nodejs#30196
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: nodejs#30033

PR-URL: nodejs#30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This allows removing custom code for setting the current async ids
and running nextTicks.

PR-URL: nodejs#30236
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reduce the number of different scopes we use for async callbacks.

PR-URL: nodejs#30236
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This makes it possible to tell whether a signal is being tracked in JS.

PR-URL: nodejs#30229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Run `EndStartedProfilers` on Environment teardown.

This is part of a series of changes to make embedding easier, by
requiring fewer internal methods to build a fully functioning
Node.js instance.

PR-URL: nodejs#30229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Run inspector cleanup code on Environment teardown.

This is part of a series of changes to make embedding easier, by
requiring fewer internal methods to build a fully functioning
Node.js instance.

PR-URL: nodejs#30229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This makes more sense than releasing and re-wrapping the raw pointer.

PR-URL: nodejs#30229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This is part of a series of changes to make embedding easier, by
requiring fewer internal methods to build a fully functioning
Node.js instance.

This also aligns the worker_threads code with the main thread code.

PR-URL: nodejs#30229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This was previously done inconsistently, sometimes before, sometimes
after emitting the event.

PR-URL: nodejs#30210
Fixes: nodejs#30209
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This avoids piling up `'listening'` event listeners if
`.bind()` fails repeatedly.

Fixes: nodejs#30209

PR-URL: nodejs#30210
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
lundibundi and others added 10 commits November 21, 2019 13:37
PR-URL: nodejs#30371
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Fixes: nodejs#30344

PR-URL: nodejs#30355
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: nodejs#30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#30312
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cover 'close' method (in Dir class) with tests
Add 2 tests for full covering of method 'close' in class Dir
1. If pass smth that not string as a callback - throw an exception
2. If do .close() on already closed directory - throw an exception

PR-URL: nodejs#30310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: v8/v8@7.9.317.20...7.9.317.23

PR-URL: nodejs#30560
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorins
Copy link
Contributor

Updated against master one more time. Since I've not heard anything from @BridgeAR I'm going to go a head and publish this release (once i get one more clean CI / build).

I've gone ahead and changed @BridgeAR's name on the changelog to my own since I'll be signing and pushing the release

@MylesBorins MylesBorins force-pushed the v13.2.0-proposal branch 2 times, most recently from 6f72551 to e65257e Compare November 21, 2019 18:51
@nodejs nodejs deleted a comment from nodejs-github-bot Nov 21, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@BethGriggs
Copy link
Member

I just spotted that the PR-URL is missing from the commit message - e65257e

I don't know how much impact that'll have and/or whether it's necessary to update and rebuild (I know we've had some CI issues during this release)

Notable changes:

* addons:
  * Deprecate one- and two-argument `AtExit()`. Use the three-argument
    variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead
    (Anna Henningsen) nodejs#30227
* child_process,cluster:
  * The `serialization` option is added that allows child process
    IPC to use the V8 serialization API (to e.g., pass through data
    types like sets or maps) (Anna Henningsen)
    nodejs#30162
* deps:
  * Update V8 to 7.9
  * Update `npm` to 6.13.0 (Ruy Adorno)
    nodejs#30271
* embedder:
  * Exposes the ability to pass cli flags / options through an API
    as embedder (Shelley Vohr)
    nodejs#30466
  * Allow adding linked bindings to Environment (Anna Henningsen)
    nodejs#30274
* esm:
  * Unflag --experimental-modules (Guy Bedford)
    nodejs#29866
* stream:
  * Add `writable.writableCorked` property (Robert Nagy)
    nodejs#29012
* worker:
  * Allow specifying resource limits (Anna Henningsen)
    nodejs#26628
* v8:
  * The Serialization API is now stable (Anna Henningsen)
    nodejs#30234

PR-URL: nodejs#30547
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 21, 2019

@BethGriggs fixed. Won't bother kicking off another CITGM. Fingers crossed that https://ci.nodejs.org/job/node-test-pull-request/26824/ is green

Kicked off a fresh release build

@MylesBorins
Copy link
Contributor

Between all the CI runs we've done there has been at least a single green run on every system. I'm going to let the remaining retries run and likely promote independent of the results. If anyone has concerns about the flakyness of CI please lmk

@MylesBorins MylesBorins merged commit 8eda60c into nodejs:v13.x Nov 21, 2019
MylesBorins added a commit that referenced this pull request Nov 21, 2019
MylesBorins added a commit that referenced this pull request Nov 21, 2019
Notable changes:

* addons:
  * Deprecate one- and two-argument `AtExit()`. Use the three-argument
    variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead
    (Anna Henningsen) #30227
* child_process,cluster:
  * The `serialization` option is added that allows child process
    IPC to use the V8 serialization API (to e.g., pass through data
    types like sets or maps) (Anna Henningsen)
    #30162
* deps:
  * Update V8 to 7.9
  * Update `npm` to 6.13.0 (Ruy Adorno)
    #30271
* embedder:
  * Exposes the ability to pass cli flags / options through an API
    as embedder (Shelley Vohr)
    #30466
  * Allow adding linked bindings to Environment (Anna Henningsen)
    #30274
* esm:
  * Unflag --experimental-modules (Guy Bedford)
    #29866
* stream:
  * Add `writable.writableCorked` property (Robert Nagy)
    #29012
* worker:
  * Allow specifying resource limits (Anna Henningsen)
    #26628
* v8:
  * The Serialization API is now stable (Anna Henningsen)
    #30234

PR-URL: #30547
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Nov 21, 2019
@BridgeAR BridgeAR deleted the v13.2.0-proposal branch January 20, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.