test: recognize wpt completion error

PR-URL: #50429 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
nodejs · Nov 3, 2023 · a00f0b1 · a00f0b1
1 parent 075ae82
commit a00f0b1
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 0 deletions.
diff --git a/test/common/wpt.js b/test/common/wpt.js
@@ -838,6 +838,16 @@ class WPTRunner {
       this.fail(spec, { name: 'WPT testharness timeout' }, kTimeout);
       // Mark the whole test as TIMEOUT in wpt.fyi report.
       reportResult?.finish('TIMEOUT');
+    } else if (status !== kPass) {
+      // No need to record this synthetic failure with wpt.fyi.
+      this.fail(spec, {
+        status: status,
+        name: 'WPT test harness error',
+        message: harnessStatus.message,
+        stack: harnessStatus.stack,
+      }, status);
+      // Mark the whole test as ERROR in wpt.fyi report.
+      reportResult?.finish('ERROR');
     } else {
       reportResult?.finish();
     }

diff --git a/test/wpt/status/console.json b/test/wpt/status/console.json
@@ -7,5 +7,8 @@
         "console namespace: operation dir(optional any, optional object?)"
       ]
     }
+  },
+  "idlharness-shadowrealm.window.js": {
+    "skip": "ShadowRealm support is not enabled"
   }
 }
diff --git a/test/wpt/status/encoding.json b/test/wpt/status/encoding.json
@@ -39,6 +39,9 @@
   "idlharness.any.js": {
     "skip": "No implementation of TextDecoderStream and TextEncoderStream"
   },
+  "idlharness-shadowrealm.window.js": {
+    "skip": "ShadowRealm support is not enabled"
+  },
   "replacement-encodings.any.js": {
     "skip": "decoding-helpers.js needs XMLHttpRequest"
   },

diff --git a/test/wpt/status/hr-time.json b/test/wpt/status/hr-time.json
@@ -6,6 +6,9 @@
       ]
     }
   },
+  "idlharness-shadowrealm.window.js": {
+    "skip": "ShadowRealm support is not enabled"
+  },
   "window-worker-timeOrigin.window.js": {
     "skip": "depends on URL.createObjectURL(blob)"
   }

diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json
@@ -6,6 +6,9 @@
       ]
     }
   },
+  "idlharness-shadowrealm.window.js": {
+    "skip": "ShadowRealm support is not enabled"
+  },
   "piping/general-addition.any.js": {
     "fail": {
       "expected": [

diff --git a/test/wpt/status/url.json b/test/wpt/status/url.json
@@ -1,4 +1,7 @@
 {
+  "idlharness-shadowrealm.window.js": {
+    "skip": "ShadowRealm support is not enabled"
+  },
   "percent-encoding.window.js": {
     "skip": "TODO: port from .window.js"
   },

diff --git a/test/wpt/status/user-timing.json b/test/wpt/status/user-timing.json
@@ -1,4 +1,7 @@
 {
+  "idlharness-shadowrealm.window.js": {
+    "skip": "ShadowRealm support is not enabled"
+  },
   "invoke_with_timing_attributes.worker.js": {
     "skip": "importScripts not supported"
   },