test: refactor test-https-agent-additional-options

Move callback to location where it is less confusing. PR-URL: #27830 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · May 28, 2019 · a4c1fd5 · a4c1fd5
1 parent 17abc8c
commit a4c1fd5
Showing 1 changed file with 21 additions and 26 deletions.
diff --git a/test/parallel/test-https-agent-additional-options.js b/test/parallel/test-https-agent-additional-options.js
@@ -42,34 +42,12 @@ const updatedValues = new Map([
 function variations(iter, port, cb) {
   const { done, value } = iter.next();
   if (done) {
-    return common.mustCall(cb);
-  } else {
-    const [key, val] = value;
     return common.mustCall((res) => {
       res.resume();
       https.globalAgent.once('free', common.mustCall(() => {
-        https.get(
-          Object.assign({}, getBaseOptions(port), { [key]: val }),
-          variations(iter, port, cb)
-        );
-      }));
-    });
-  }
-}
-
-server.listen(0, common.mustCall(() => {
-  const port = server.address().port;
-  const globalAgent = https.globalAgent;
-  globalAgent.keepAlive = true;
-  https.get(getBaseOptions(port), variations(
-    updatedValues.entries(),
-    port,
-    common.mustCall((res) => {
-      res.resume();
-      globalAgent.once('free', common.mustCall(() => {
         // Verify that different keep-alived connections are created
         // for the base call and each variation
-        const keys = Object.keys(globalAgent.freeSockets);
+        const keys = Object.keys(https.globalAgent.freeSockets);
         assert.strictEqual(keys.length, 1 + updatedValues.size);
         let i = 1;
         for (const [, value] of updatedValues) {
@@ -80,9 +58,26 @@ server.listen(0, common.mustCall(() => {
           );
           i++;
         }
-        globalAgent.destroy();
+        https.globalAgent.destroy();
         server.close();
       }));
-    })
-  ));
+    });
+  } else {
+    const [key, val] = value;
+    return common.mustCall((res) => {
+      res.resume();
+      https.globalAgent.once('free', common.mustCall(() => {
+        https.get(
+          Object.assign({}, getBaseOptions(port), { [key]: val }),
+          variations(iter, port, cb)
+        );
+      }));
+    });
+  }
+}
+
+server.listen(0, common.mustCall(() => {
+  const port = server.address().port;
+  https.globalAgent.keepAlive = true;
+  https.get(getBaseOptions(port), variations(updatedValues.entries(), port));
 }));