Skip to content

Commit

Permalink
src: remove .h if -inl.h is already included
Browse files Browse the repository at this point in the history
This commit removes the normal header file include if an internal one
is specified as per the CPP_STYLE_GUIDE.

PR-URL: #21381
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
  • Loading branch information
danbev committed Jun 20, 2018
1 parent b72de3d commit a71d5fc
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion src/bootstrapper.cc
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "node.h"
#include "env.h"
#include "env-inl.h"
#include "node_internals.h"
#include "v8.h"
Expand Down
2 changes: 0 additions & 2 deletions src/callback_scope.cc
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#include "node.h"
#include "async_wrap.h"
#include "async_wrap-inl.h"
#include "env.h"
#include "env-inl.h"
#include "v8.h"

Expand Down
2 changes: 0 additions & 2 deletions src/exceptions.cc
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#include "node.h"
#include "node_internals.h"
#include "env.h"
#include "env-inl.h"
#include "util.h"
#include "util-inl.h"
#include "v8.h"
#include "uv.h"
Expand Down
2 changes: 0 additions & 2 deletions src/node_encoding.cc
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#include "node.h"
#include "env.h"
#include "env-inl.h"
#include "string_bytes.h"
#include "util.h"
#include "util-inl.h"
#include "v8.h"

Expand Down
1 change: 0 additions & 1 deletion src/node_platform.cc
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#include "node_platform.h"
#include "node_internals.h"

#include "env.h"
#include "env-inl.h"
#include "util.h"
#include <algorithm>
Expand Down
2 changes: 0 additions & 2 deletions src/node_process.cc
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#include "node.h"
#include "node_internals.h"
#include "env.h"
#include "env-inl.h"
#include "util.h"
#include "util-inl.h"
#include "uv.h"
#include "v8.h"
Expand Down

0 comments on commit a71d5fc

Please sign in to comment.