Skip to content

Commit

Permalink
tools: replace custom lint rule for getter/setter
Browse files Browse the repository at this point in the history
Replace custom `no-definegetter-definesetter` lint rule with ESLint's
built-in `no-restricted-properties`.

Refs: #9112 (review)
PR-URL: #9194
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Oct 24, 2016
1 parent 1518cc1 commit a83354a
Showing 2 changed files with 6 additions and 33 deletions.
7 changes: 6 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
@@ -63,6 +63,12 @@ rules:
object: assert,
property: deepEqual,
message: Please use assert.deepStrictEqual().
}, {
property: __defineGetter__,
message: __defineGetter__ is deprecated.
}, {
property: __defineSetter__,
message: __defineSetter__ is deprecated.
}]

# Stylistic Issues
@@ -112,7 +118,6 @@ rules:
align-multiline-assignment: 2
assert-fail-single-argument: 2
new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
no-definegetter-definesetter: 2

# Global scoped method and vars
globals:
32 changes: 0 additions & 32 deletions tools/eslint-rules/no-definegetter-definesetter.js

This file was deleted.

0 comments on commit a83354a

Please sign in to comment.