Skip to content

Commit

Permalink
test: updated tls-getcipher test
Browse files Browse the repository at this point in the history
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.

PR-URL: #9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Ethan-Arrowood authored and jasnell committed Dec 5, 2016
1 parent 9042a91 commit be1f52b
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions test/parallel/test-tls-getcipher.js
Original file line number Diff line number Diff line change
@@ -1,37 +1,37 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var tls = require('tls');
const assert = require('assert');
const tls = require('tls');

var fs = require('fs');
var cipher_list = ['AES128-SHA256', 'AES256-SHA256'];
var cipher_version_pattern = /TLS|SSL/;
var options = {
const fs = require('fs');
const cipher_list = ['AES128-SHA256', 'AES256-SHA256'];
const cipher_version_pattern = /TLS|SSL/;
const options = {
key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'),
ciphers: cipher_list.join(':'),
honorCipherOrder: true
};

var server = tls.createServer(options,
common.mustCall(function(cleartextStream) {}));
const server = tls.createServer(options,
common.mustCall(function(cleartextStream) {}));

server.listen(0, '127.0.0.1', function() {
var client = tls.connect({
server.listen(0, '127.0.0.1', common.mustCall(function() {
const client = tls.connect({
host: '127.0.0.1',
port: this.address().port,
ciphers: cipher_list.join(':'),
rejectUnauthorized: false
}, function() {
var cipher = client.getCipher();
assert.equal(cipher.name, cipher_list[0]);
}, common.mustCall(function() {
const cipher = client.getCipher();
assert.strictEqual(cipher.name, cipher_list[0]);
assert(cipher_version_pattern.test(cipher.version));
client.end();
server.close();
});
});
}));
}));

0 comments on commit be1f52b

Please sign in to comment.