Skip to content

Commit

Permalink
src: make parameter name const reference in method TriggerNodeReport
Browse files Browse the repository at this point in the history
PR-URL: #26397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
gengjiawen authored and BridgeAR committed Mar 14, 2019
1 parent bb374d4 commit c7bd21c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/node_report.cc
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ std::string TriggerNodeReport(Isolate* isolate,
Environment* env,
const char* message,
const char* trigger,
std::string name,
const std::string& name,
Local<String> stackstr) {
std::ostringstream oss;
std::string filename;
Expand Down
2 changes: 1 addition & 1 deletion src/node_report.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ std::string TriggerNodeReport(v8::Isolate* isolate,
node::Environment* env,
const char* message,
const char* trigger,
std::string name,
const std::string& name,
v8::Local<v8::String> stackstr);
void GetNodeReport(v8::Isolate* isolate,
node::Environment* env,
Expand Down

0 comments on commit c7bd21c

Please sign in to comment.