Skip to content

Commit

Permalink
test: add coverage for dgram _createSocketHandle()
Browse files Browse the repository at this point in the history
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: #11291
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
cjihrig authored and MylesBorins committed Mar 9, 2017
1 parent c4e1af7 commit caf1ba1
Showing 1 changed file with 39 additions and 0 deletions.
39 changes: 39 additions & 0 deletions test/parallel/test-dgram-create-socket-handle.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const UDP = process.binding('udp_wrap').UDP;
const _createSocketHandle = dgram._createSocketHandle;

// Throws if an "existing fd" is passed in.
assert.throws(() => {
_createSocketHandle(common.localhostIPv4, 0, 'udp4', 42);
}, /^AssertionError: false == true$/);

{
// Create a handle that is not bound.
const handle = _createSocketHandle(null, null, 'udp4');

assert(handle instanceof UDP);
assert.strictEqual(typeof handle.fd, 'number');
assert(handle.fd < 0);
}

{
// Create a bound handle.
const handle = _createSocketHandle(common.localhostIPv4, 0, 'udp4');

assert(handle instanceof UDP);
assert.strictEqual(typeof handle.fd, 'number');

if (!common.isWindows)
assert(handle.fd > 0);
}

{
// Return an error if binding fails.
const err = _createSocketHandle('localhost', 0, 'udp4');

assert.strictEqual(typeof err, 'number');
assert(err < 0);
}

0 comments on commit caf1ba1

Please sign in to comment.