Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for dgram _createSocketHandle() #11291

Merged
merged 1 commit into from
Feb 13, 2017
Merged

test: add coverage for dgram _createSocketHandle() #11291

merged 1 commit into from
Feb 13, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 10, 2017

This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 10, 2017
@cjihrig cjihrig added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 10, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 13, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/6376/

EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/6390/
EDIT: CI again: https://ci.nodejs.org/job/node-test-pull-request/6392/

@cjihrig cjihrig force-pushed the create-socket-handle branch 3 times, most recently from 7896f47 to 1da95a0 Compare February 13, 2017 21:54
@cjihrig
test: add coverage for dgram _createSocketHandle()
a2fac32 
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: nodejs#11291
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig force-pushed the create-socket-handle branch from 1da95a0 to a2fac32 Compare February 13, 2017 22:26
@cjihrig cjihrig merged commit a2fac32 into nodejs:master Feb 13, 2017
@cjihrig cjihrig deleted the create-socket-handle branch February 13, 2017 22:27
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
test: add coverage for dgram _createSocketHandle()
93d3a3a 
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: nodejs#11291
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 14, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@cjihrig @jasnell
test: add coverage for dgram _createSocketHandle()
ee93460 
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: #11291
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@cjihrig @jasnell
test: add coverage for dgram _createSocketHandle()
6853412 
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: #11291
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: add coverage for dgram _createSocketHandle()
874ef9d 
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: #11291
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: add coverage for dgram _createSocketHandle()
caf1ba1 
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: #11291
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjihrig @jasnell @nodejs-github-bot