-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lib: return boolean from child.send()
Previous change reinstated returning boolean from child.send() but missed one instance where undefined might be returned instead. PR-URL: #3577 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
- Loading branch information
Showing
2 changed files
with
22 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,29 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const path = require('path'); | ||
const net = require('net'); | ||
const fork = require('child_process').fork; | ||
const spawn = require('child_process').spawn; | ||
|
||
const n = fork(common.fixturesDir + '/empty.js'); | ||
const emptyFile = path.join(common.fixturesDir, 'empty.js'); | ||
|
||
const n = fork(emptyFile); | ||
|
||
const rv = n.send({ hello: 'world' }); | ||
assert.strictEqual(rv, true); | ||
|
||
const spawnOptions = { stdio: ['pipe', 'pipe', 'pipe', 'ipc'] }; | ||
const s = spawn(process.execPath, [emptyFile], spawnOptions); | ||
var handle = null; | ||
s.on('exit', function() { | ||
handle.close(); | ||
}); | ||
|
||
net.createServer(common.fail).listen(common.PORT, function() { | ||
handle = this._handle; | ||
assert.strictEqual(s.send('one', handle), true); | ||
assert.strictEqual(s.send('two', handle), true); | ||
assert.strictEqual(s.send('three'), false); | ||
assert.strictEqual(s.send('four'), false); | ||
}); |