fixup: ref/unref should still work when destroyed

nodejs · Dec 13, 2019 · d249fc2 · d249fc2
1 parent 33b3eb4
commit d249fc2
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lib/internal/timers.js b/lib/internal/timers.js
@@ -207,23 +207,25 @@ Timeout.prototype.refresh = function() {
 };
 
 Timeout.prototype.unref = function() {
-  if (this[kRefed] && !this._destroyed) {
+  if (this[kRefed]) {
     this[kRefed] = false;
-    decRefCount();
+    if (!this._destroyed)
+      decRefCount();
   }
   return this;
 };
 
 Timeout.prototype.ref = function() {
-  if (!this[kRefed] && !this._destroyed) {
+  if (!this[kRefed]) {
     this[kRefed] = true;
-    incRefCount();
+    if (!this._destroyed)
+      incRefCount();
   }
   return this;
 };
 
 Timeout.prototype.hasRef = function() {
-  return !!(this[kRefed] && !this._destroyed);
+  return this[kRefed];
 };
 
 function TimersList(expiry, msecs) {