tools: add console to the list of restricted globals

PR-URL: #42012 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
nodejs · Apr 24, 2022 · d45a8b3 · d45a8b3
1 parent b3672f3
commit d45a8b3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -89,6 +89,8 @@ rules:
       message: Use `const { clearInterval } = require('timers');` instead of the global.
     - name: clearTimeout
       message: Use `const { clearTimeout } = require('timers');` instead of the global.
+    - name: console
+      message: Use `const { console } = require('internal/console/global');` instead of the global.
     - name: crypto
       message: Use `const { crypto } = require('internal/crypto/webcrypto');` instead of the global.
     - name: Crypto

diff --git a/lib/internal/freeze_intrinsics.js b/lib/internal/freeze_intrinsics.js
@@ -19,7 +19,6 @@
 // https://github.com/google/caja/blob/HEAD/src/com/google/caja/ses/repairES5.js
 // https://github.com/tc39/proposal-ses/blob/e5271cc42a257a05dcae2fd94713ed2f46c08620/shim/src/freeze.js
 
-/* global console */
 'use strict';
 
 const {
@@ -133,6 +132,8 @@ const {
 } = globalThis;
 
 module.exports = function() {
+  const { Console } = require('internal/console/constructor');
+  const { console } = require('internal/console/global');
   const {
     clearImmediate,
     clearInterval,
@@ -216,7 +217,7 @@ module.exports = function() {
     PromisePrototype, // 27.2
 
     // Other APIs / Web Compatibility
-    console.Console.prototype,
+    Console.prototype,
     WebAssembly.Module.prototype,
     WebAssembly.Instance.prototype,
     WebAssembly.Table.prototype,

diff --git a/lib/internal/v8_prof_polyfill.js b/lib/internal/v8_prof_polyfill.js
@@ -27,7 +27,7 @@
 
 'use strict';
 
-/* eslint-disable node-core/prefer-primordials */
+/* eslint-disable node-core/prefer-primordials, no-restricted-globals */
 /* global console */
 
 module.exports = { versionCheck };
@@ -73,7 +73,6 @@ function read(fileName) {
 }
 const quit = process.exit;
 // Polyfill "readline()".
-// eslint-disable-next-line no-restricted-globals
 const logFile = globalThis.arguments[globalThis.arguments.length - 1];
 try {
   fs.accessSync(logFile);
@@ -163,7 +162,6 @@ function macCppfiltNm(out) {
   });
 }
 
-// eslint-disable-next-line no-restricted-globals
 Object.assign(globalThis, {
   os,
   print,