Skip to content

Commit

Permalink
build: rework ASAN build on Actions
Browse files Browse the repository at this point in the history
Changed from Debug build to Release build to avoid out of memory issues
during the link step. This should also speed up the build.

Commented out the test runner for now, since there are too many ASAN
warnings there to be useful. We should re-enable the test runner once
our ASAN warnings are fixed.

Simplify the environment: instead of running on a container, runs
directly on the host. With this, ASAN build looks identical to other
builds in GitHub Actions, with the exception of the `--enable-asan`
flag.

Ref: https://github.com/nodejs/node/issue/32257
Ref: #32324
  • Loading branch information
mmarchini committed Mar 19, 2020
1 parent 6a34901 commit daf2add
Showing 1 changed file with 16 additions and 20 deletions.
36 changes: 16 additions & 20 deletions .github/workflows/ASAN.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,19 @@ name: node ASAN
on: [push, pull_request]

jobs:
ubuntu-build:
runs-on: ubuntu-latest
container: gengjiawen/node-build:2020-02-14
steps:
- uses: actions/checkout@v2
- name: Build
# TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough
# memory to build with debug and ASAN. Allow this build to fail until
# we figure out a workaround, or until we update to 8.2 (where build
# is passing).
continue-on-error: true
run: |
npx envinfo
./configure --debug --enable-asan --ninja && ninja -C out/Debug
- name: Test
env:
ASAN_OPTIONS: halt_on_error=0
continue-on-error: true
run: |
python3 tools/test.py -J --mode=debug
build-linux-asan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Environment Information
run: npx envinfo
- name: Build
run: ./configure --enable-asan && make -j2
# TODO(mmarchini): re-enable tests when we fix all issues pointed out
# by ASAN
# - name: Test
# env:
# ASAN_OPTIONS: halt_on_error=0
# continue-on-error: true
# run: |
# python3 tools/test.py -J

0 comments on commit daf2add

Please sign in to comment.