Skip to content

Commit

Permalink
doc: correct entry for electron v4.0.4
Browse files Browse the repository at this point in the history
`abi_version_registry.json` incorrectly specified that electron v4.0.4
used `NODE_MODULE_VERSION` 64, but in fact it uses 69.

See:

* electron/electron#16687
* https://github.com/electron/electron/releases/tag/v4.0.4
* electron/node-abi@9e4c1a6

PR-URL: #27394
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
jacobq authored and targos committed May 20, 2019
1 parent 6e2c8d0 commit df01645
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions doc/abi_version_registry.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
{ "modules": 72, "runtime": "node", "variant": "v8_7.4", "versions": "12.0.0-pre" },
{ "modules": 71, "runtime": "node", "variant": "v8_7.3", "versions": "12.0.0-pre" },
{ "modules": 70, "runtime": "electron", "variant": "electron", "versions": "5" },
{ "modules": 69, "runtime": "electron", "variant": "electron", "versions": "^4.0.5" },
{ "modules": 69, "runtime": "electron", "variant": "electron", "versions": "^4.0.4" },
{ "modules": 68, "runtime": "node", "variant": "v8_7.1", "versions": "12.0.0-pre" },
{ "modules": 67, "runtime": "node", "variant": "node", "versions": "11" },
{ "modules": 66, "runtime": "node", "variant": "v8_6.9", "versions": "11.0.0-pre" },
{ "modules": 65, "runtime": "node", "variant": "v8_6.8", "versions": "11.0.0-pre" },
{ "modules": 65, "runtime": "node", "variant": "debian-openssl_1.1.1", "versions": "10" },
{ "modules": 64, "runtime": "node", "variant": "node", "versions": "10" },
{ "modules": 64, "runtime": "electron", "variant": "electron", "versions": ">=3 <4.0.5" },
{ "modules": 64, "runtime": "electron", "variant": "electron", "versions": ">=3 <4.0.4" },
{ "modules": 63, "runtime": "node", "variant": "v8_6.6", "versions": "10.0.0-pre" },
{ "modules": 62, "runtime": "node", "variant": "v8_6.5", "versions": "10.0.0-pre" },
{ "modules": 61, "runtime": "node", "variant": "v8_6.4", "versions": "10.0.0-pre" },
Expand Down

0 comments on commit df01645

Please sign in to comment.