fixup! esm: refactor esm tests out of test/message

nodejs · Dec 30, 2021 · eaf4cba · eaf4cba
1 parent c828d46
commit eaf4cba
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 7 deletions.
diff --git a/test/es-module/test-esm-export-not-found.mjs b/test/es-module/test-esm-export-not-found.mjs
@@ -28,7 +28,7 @@ const importStatementMultiline = `import {
     stderr += data;
   });
   child.on('close', () => {
-    ok(stderr.toString().includes(
+    ok(stderr.includes(
       'SyntaxError: The requested module \'./module-named-exports.mjs\' ' +
       'does not provide an export named \'notfound\''
     ));

diff --git a/test/es-module/test-esm-import-json-named-export.mjs b/test/es-module/test-esm-import-json-named-export.mjs
@@ -15,7 +15,7 @@ child.stderr.on('data', (data) => {
   stderr += data;
 });
 child.on('close', () => {
-  ok(stderr.toString().includes(
+  ok(stderr.includes(
     'SyntaxError: The requested module \'../experimental.json\' ' +
     'does not provide an export named \'ofLife\''
   ));

diff --git a/test/es-module/test-esm-loader-not-found.mjs b/test/es-module/test-esm-loader-not-found.mjs
@@ -16,7 +16,6 @@ child.stderr.on('data', (data) => {
   stderr += data;
 });
 child.on('close', () => {
-  stderr = stderr.toString();
   ok(stderr.includes(
     'Error [ERR_MODULE_NOT_FOUND]: Cannot find package \'i-dont-exist\' ' +
     'imported from'

diff --git a/test/es-module/test-esm-loader-obsolete-hooks.mjs b/test/es-module/test-esm-loader-obsolete-hooks.mjs
@@ -18,7 +18,6 @@ child.stderr.on('data', (data) => {
   stderr += data;
 });
 child.on('close', () => {
-  stderr = stderr.toString();
   ok(stderr.includes(
     'DeprecationWarning: Obsolete loader hook(s) supplied and will be ' +
     'ignored: dynamicInstantiate, getFormat, getSource, transformSource'

diff --git a/test/es-module/test-esm-loader-with-syntax-error.mjs b/test/es-module/test-esm-loader-with-syntax-error.mjs
@@ -16,7 +16,6 @@ child.stderr.on('data', (data) => {
   stderr += data;
 });
 child.on('close', () => {
-  stderr = stderr.toString();
   ok(stderr.includes(
     'SyntaxError: Malformed arrow function parameter list'
   ));

diff --git a/test/es-module/test-esm-module-not-found-commonjs-hint.mjs b/test/es-module/test-esm-module-not-found-commonjs-hint.mjs
@@ -28,6 +28,6 @@ import { execPath } from 'process';
     stderr += data;
   });
   child.on('close', () => {
-    ok(stderr.toString().includes(expected));
+    ok(stderr.includes(expected));
   });
 });
diff --git a/test/es-module/test-esm-syntax-error.mjs b/test/es-module/test-esm-syntax-error.mjs
@@ -14,7 +14,7 @@ child.stderr.on('data', (data) => {
   stderr += data;
 });
 child.on('close', () => {
-  ok(stderr.toString().includes(
+  ok(stderr.includes(
     'SyntaxError: Malformed arrow function parameter list'
   ));
 });