inspector: report default context

Fixes: #8426 PR-URL: #8502 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
nodejs · Sep 20, 2016 · efe4d19 · efe4d19
1 parent 57b7e85
commit efe4d19
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -328,7 +328,7 @@ class V8NodeInspector : public v8_inspector::V8InspectorClient {
   V8NodeInspector(AgentImpl* agent, node::Environment* env,
                   v8::Platform* platform)
                   : agent_(agent),
-                    isolate_(env->isolate()),
+                    env_(env),
                     platform_(platform),
                     terminated_(false),
                     running_nested_loop_(false),
@@ -348,7 +348,7 @@ class V8NodeInspector : public v8_inspector::V8InspectorClient {
         Mutex::ScopedLock scoped_lock(agent_->pause_lock_);
         agent_->pause_cond_.Wait(scoped_lock);
       }
-      while (v8::platform::PumpMessageLoop(platform_, isolate_))
+      while (v8::platform::PumpMessageLoop(platform_, env_->isolate()))
         {}
     } while (!terminated_);
     terminated_ = false;
@@ -376,13 +376,18 @@ class V8NodeInspector : public v8_inspector::V8InspectorClient {
     session_->dispatchProtocolMessage(message);
   }
 
+  v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId)
+      override {
+    return env_->context();
+  }
+
   V8Inspector* inspector() {
     return inspector_.get();
   }
 
  private:
   AgentImpl* agent_;
-  v8::Isolate* isolate_;
+  node::Environment* env_;
   v8::Platform* platform_;
   bool terminated_;
   bool running_nested_loop_;

diff --git a/test/inspector/test-inspector.js b/test/inspector/test-inspector.js
@@ -141,6 +141,13 @@ function testInspectScope(session) {
         }
       }, setupExpectValue(1002)
     ],
+    [
+      {
+        'method': 'Runtime.evaluate', 'params': {
+          'expression': '5 * 5'
+        }
+      }, (message) => assert.strictEqual(25, message['result']['value'])
+    ],
   ]);
 }