Skip to content

Commit

Permalink
deps: update v8_inspector
Browse files Browse the repository at this point in the history
Pick the latest v8_inspector [1] with:
* V8 5.1 compatibility
* Modify parse builder templates to make coverity happy
* The whitespace differences in the jinja2 sub-dependency do exist
  upstream. I am not sure how I missed them in the original import
  (ed2eac).

[1] pavelfeldman/v8_inspector@3b56732

PR-URL: #7118
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
  • Loading branch information
ofrobots authored and Fishrock123 committed Jul 5, 2016
1 parent 643b33b commit f4777c7
Showing 3 changed files with 16 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -180,6 +180,11 @@ def create_primitive_type_definition(type):
"integer": "int",
"boolean": "bool"
}
defaults = {
"number": "0",
"integer": "0",
"boolean": "false"
}
jsontypes = {
"number": "TypeNumber",
"integer": "TypeNumber",
@@ -195,6 +200,7 @@ def create_primitive_type_definition(type):
"raw_type": typedefs[type],
"raw_pass_type": typedefs[type],
"raw_return_type": typedefs[type],
"default_value": defaults[type]
}

type_definitions = {}
Original file line number Diff line number Diff line change
@@ -187,7 +187,14 @@ public:
}

private:
{{type.id}}() { }
{{type.id}}()
{
{% for property in type.properties %}
{% if not(property.optional) and "default_value" in resolve_type(property) %}
m_{{property.name}} = {{resolve_type(property).default_value}};
{%endif %}
{% endfor %}
}

{% for property in type.properties %}
{% if property.optional %}
4 changes: 2 additions & 2 deletions deps/v8_inspector/platform/v8_inspector/V8Compat.h
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@

#include <v8.h>

#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2)
#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1)
namespace v8 {

// In standalone V8 inspector this is expected to be noop anyways...
@@ -23,6 +23,6 @@ class V8_EXPORT MicrotasksScope {

} // namespace v8

#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2)
#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1)

#endif // V8Compat_h

0 comments on commit f4777c7

Please sign in to comment.