Skip to content

Commit

Permalink
src: update v8::Object::GetPropertyNames() usage
Browse files Browse the repository at this point in the history
Use the non-deprecated version of GetPropertyNames().

PR-URL: #23660
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
cjihrig authored and MylesBorins committed Oct 30, 2018
1 parent 3e4032a commit f5cadf6
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/node_contextify.cc
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,12 @@ void ContextifyContext::PropertyEnumeratorCallback(
if (ctx->context_.IsEmpty())
return;

args.GetReturnValue().Set(ctx->sandbox()->GetPropertyNames());
Local<Array> properties;

if (!ctx->sandbox()->GetPropertyNames(ctx->context()).ToLocal(&properties))
return;

args.GetReturnValue().Set(properties);
}

// static
Expand Down

0 comments on commit f5cadf6

Please sign in to comment.