Skip to content

Commit

Permalink
test: inline common module boolean
Browse files Browse the repository at this point in the history
PR-URL: #23479
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
ashleysimpson authored and MylesBorins committed Nov 29, 2018
1 parent 011116c commit f6e1acf
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 10 deletions.
2 changes: 1 addition & 1 deletion test/addons/load-long-path/test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
const common = require('../../common');
if (common.isWOW64)
if (common.isWindows && (process.env.PROCESSOR_ARCHITEW6432 !== undefined))
common.skip('doesn\'t work on WOW64');

const fs = require('fs');
Expand Down
5 changes: 0 additions & 5 deletions test/common/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,11 +213,6 @@ Platform check for SunOS.

Platform check for Windows.

### isWOW64
* [&lt;boolean>]

Platform check for Windows 32-bit on Windows 64-bit.

### localhostIPv4
* [&lt;string>]

Expand Down
2 changes: 0 additions & 2 deletions test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ const isMainThread = (() => {
})();

const isWindows = process.platform === 'win32';
const isWOW64 = isWindows && (process.env.PROCESSOR_ARCHITEW6432 !== undefined);
const isAIX = process.platform === 'aix';
const isLinuxPPCBE = (process.platform === 'linux') &&
(process.arch === 'ppc64') &&
Expand Down Expand Up @@ -720,7 +719,6 @@ module.exports = {
isOSX,
isSunOS,
isWindows,
isWOW64,
localIPv6Hosts,
mustCall,
mustCallAsync,
Expand Down
2 changes: 0 additions & 2 deletions test/common/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import common from './index.js';
const {
isMainThread,
isWindows,
isWOW64,
isAIX,
isLinuxPPCBE,
isSunOS,
Expand Down Expand Up @@ -54,7 +53,6 @@ const {
export {
isMainThread,
isWindows,
isWOW64,
isAIX,
isLinuxPPCBE,
isSunOS,
Expand Down

0 comments on commit f6e1acf

Please sign in to comment.