fixup! util: runtime deprecate promisify-ing a function returning a…

… `Promise`
nodejs · Sep 16, 2023 · f9726f9 · f9726f9
1 parent 2fb3d51
commit f9726f9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -410,7 +410,8 @@ function promisify(original) {
         }
       });
       if (isPromise(ReflectApply(original, this, args))) {
-        process.emitWarning('Calling promisify on a function that returns a Promise is likely a mistake.');
+        process.emitWarning('Calling promisify on a function that returns a Promise is likely a mistake.',
+                            'DeprecationWarning', 'DEP0174');
       }
     });
   }

diff --git a/test/parallel/test-util-promisify.js b/test/parallel/test-util-promisify.js
@@ -16,9 +16,17 @@ const { customPromisifyArgs } = require('internal/util');
   process.off('warning', warningHandler);
 }
 
-common.expectWarning('Warning', 'Calling promisify on a function that returns a Promise is likely a mistake.');
+common.expectWarning(
+  'DeprecationWarning',
+  'Calling promisify on a function that returns a Promise is likely a mistake.',
+  'DEP0174');
 promisify(async (callback) => { callback(); })().then(common.mustCall(() => {
-  common.expectWarning('Warning', 'Calling promisify on a function that returns a Promise is likely a mistake.');
+  // We must add the second `expectWarning` call in the `.then` handler, when
+  // the first warning has already been triggered.
+  common.expectWarning(
+    'DeprecationWarning',
+    'Calling promisify on a function that returns a Promise is likely a mistake.',
+    'DEP0174');
   promisify(async () => {})().then(common.mustNotCall());
 }));