Skip to content

Commit

Permalink
test: fix flaky test-dns-any.js
Browse files Browse the repository at this point in the history
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott committed Mar 2, 2020
1 parent 6bcea0a commit fb74e98
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions test/internet/test-dns-any.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,28 +115,6 @@ function processResult(res) {
return types;
}

TEST(async function test_google(done) {
function validateResult(res) {
const types = processResult(res);
assert.ok(
types.A && types.AAAA && types.MX && types.NS && types.TXT && types.SOA,
`Missing record type, found ${Object.keys(types)}`);
}

validateResult(await dnsPromises.resolve('google.com', 'ANY'));

const req = dns.resolve(
'google.com',
'ANY',
common.mustCall(function(err, ret) {
assert.ifError(err);
validateResult(ret);
done();
}));

checkWrap(req);
});

TEST(async function test_sip2sip_for_naptr(done) {
function validateResult(res) {
const types = processResult(res);
Expand Down

0 comments on commit fb74e98

Please sign in to comment.