Skip to content

Commit

Permalink
test: switch order of assertion arguments
Browse files Browse the repository at this point in the history
this updates the arguments in order to give the actual
return value first and the given expected value second.

PR-URL: #23563
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
zzidante authored and rvagg committed Nov 28, 2018
1 parent eb0c78a commit fc23534
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-http-client-get-url.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ const URL = url.URL;
const testPath = '/foo?bar';

const server = http.createServer(common.mustCall((req, res) => {
assert.strictEqual('GET', req.method);
assert.strictEqual(testPath, req.url);
assert.strictEqual(req.method, 'GET');
assert.strictEqual(req.url, testPath);
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.write('hello\n');
res.end();
Expand Down

0 comments on commit fc23534

Please sign in to comment.