Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL: don't decode arbitrary %2e during parsing #10598

Closed
domenic opened this issue Jan 3, 2017 · 0 comments
Closed

URL: don't decode arbitrary %2e during parsing #10598

domenic opened this issue Jan 3, 2017 · 0 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@domenic
Copy link
Contributor

domenic commented Jan 3, 2017

Spec update: whatwg/url#156
Test update: web-platform-tests/wpt@d93247d
@mscdex mscdex added the url Issues and PRs related to the legacy built-in url module. label Jan 3, 2017
jasnell added a commit to jasnell/node that referenced this issue Jan 4, 2017
@jasnell
url: do not decode arbitrary %2e sequences in paths
4e38267 
Per a recent change to the URL spec, arbitrary %2e sequences
in URL paths that are not single or double dot segments are
not to be decoded.

Refs: whatwg/url#87
Refs: whatwg/url#156
Refs: web-platform-tests/wpt@d93247d
Fixes: nodejs#10598
@jasnell jasnell mentioned this issue Jan 4, 2017
Closed
3 tasks
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017
@mscdex mscdex removed the url Issues and PRs related to the legacy built-in url module. label Jan 5, 2017
@jasnell jasnell closed this as completed in 8122849 Jan 6, 2017
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 18, 2017
@jasnell @italoacasas
url: do not decode arbitrary %2e sequences in paths
4837c5f 
Per a recent change to the URL spec, arbitrary %2e sequences
in URL paths that are not single or double dot segments are
not to be decoded.

Refs: whatwg/url#87
Refs: whatwg/url#156
Refs: web-platform-tests/wpt@d93247d
Fixes: nodejs#10598
PR-URL: nodejs#10602
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 19, 2017
@jasnell @italoacasas
url: do not decode arbitrary %2e sequences in paths
0646366 
Per a recent change to the URL spec, arbitrary %2e sequences
in URL paths that are not single or double dot segments are
not to be decoded.

Refs: whatwg/url#87
Refs: whatwg/url#156
Refs: web-platform-tests/wpt@d93247d
Fixes: nodejs#10598
PR-URL: nodejs#10602
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 24, 2017
@jasnell @italoacasas
url: do not decode arbitrary %2e sequences in paths
24b0c9c 
Per a recent change to the URL spec, arbitrary %2e sequences
in URL paths that are not single or double dot segments are
not to be decoded.

Refs: whatwg/url#87
Refs: whatwg/url#156
Refs: web-platform-tests/wpt@d93247d
Fixes: nodejs#10598
PR-URL: nodejs#10602
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 27, 2017
@jasnell @italoacasas
url: do not decode arbitrary %2e sequences in paths
824978e 
Per a recent change to the URL spec, arbitrary %2e sequences
in URL paths that are not single or double dot segments are
not to be decoded.

Refs: whatwg/url#87
Refs: whatwg/url#156
Refs: web-platform-tests/wpt@d93247d
Fixes: nodejs#10598
PR-URL: nodejs#10602
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @domenic @joyeecheung