Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: extend URLSearchParams constructor (whatwg #175) #10635

Closed
jasnell opened this issue Jan 5, 2017 · 5 comments
Closed

url: extend URLSearchParams constructor (whatwg #175) #10635

jasnell opened this issue Jan 5, 2017 · 5 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@jasnell
Copy link
Member

jasnell commented Jan 5, 2017

Refs: whatwg/url#175

Proposes the ability to construct URLSearchParam instances using object and Iterable in addition to string. It is not yet clear if this will be added to the spec, but if it is, we will need to update the implementation.
@jasnell jasnell added url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jan 5, 2017
@mscdex mscdex removed the url Issues and PRs related to the legacy built-in url module. label Jan 5, 2017
@TimothyGu
Copy link
Member

CC: @nodejs/url

@jasnell
Copy link
Member Author

jasnell commented Jan 12, 2017

This landed in the spec... now needs to be implemented.
Refs: whatwg/url#175 (comment)

@TimothyGu
Copy link
Member

I'd like to merge #10399 first, which will simplify the process of implementing this.

@TimothyGu TimothyGu mentioned this issue Jan 14, 2017
Closed
2 tasks
@TimothyGu
Copy link
Member

Also needed to be tracked is whatwg/url#204.

@joyeecheung joyeecheung mentioned this issue Jan 15, 2017
Closed
3 tasks
@TimothyGu TimothyGu mentioned this issue Jan 15, 2017
Closed
11 tasks
@TimothyGu TimothyGu changed the title url: track whatwg pr #175 url: extend URLSearchParams constructor (whatwg #175) Jan 28, 2017
TimothyGu added a commit to TimothyGu/node that referenced this issue Jan 28, 2017
@TimothyGu
url: extend URLSearchParams constructor
2300a51 
Fixes: nodejs#10635
Refs: whatwg/url#175
Refs: web-platform-tests/wpt#4523
@TimothyGu TimothyGu mentioned this issue Jan 28, 2017
Closed
4 tasks
@joyeecheung joyeecheung mentioned this issue Jan 31, 2017
Closed
3 tasks
@TimothyGu
Copy link
Member

Fixed in cc48f21.

TimothyGu added a commit that referenced this issue Feb 1, 2017
@TimothyGu
url: extend URLSearchParams constructor
cc48f21 
PR-URL: #11060
Fixes: #10635
Ref: whatwg/url#175
Ref: web-platform-tests/wpt#4523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 2, 2017
@TimothyGu @italoacasas
url: extend URLSearchParams constructor
9bf29db 
PR-URL: nodejs#11060
Fixes: nodejs#10635
Ref: whatwg/url#175
Ref: web-platform-tests/wpt#4523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
TimothyGu added a commit to TimothyGu/node that referenced this issue Apr 25, 2017
@TimothyGu
url: extend URLSearchParams constructor
71d3f94 
PR-URL: nodejs#12507
Fixes: nodejs#10635
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue May 1, 2017
@TimothyGu @evanlucas
url: extend URLSearchParams constructor
b4052e6 
PR-URL: #12507
Fixes: #10635
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGu TimothyGu mentioned this issue May 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @jasnell @TimothyGu