Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-fs-readfile-tostring-fail on macOS #10742

Closed
mscdex opened this issue Jan 11, 2017 · 5 comments
Closed

Investigate flaky test-fs-readfile-tostring-fail on macOS #10742

mscdex opened this issue Jan 11, 2017 · 5 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jan 11, 2017

  • Version: master
  • Platform: macOS
  • Subsystem: test

This test just failed recently on an osx1010 node. It appears it just timed out?:

not ok 405 parallel/test-fs-readfile-tostring-fail
  ---
  duration_ms: 60.203
  severity: fail
  stack: |-
    timeout

/cc @nodejs/testing
@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. labels Jan 11, 2017
@Trott
Copy link
Member

Trott commented Jan 11, 2017

On an idle machine, this test is fast. But it gets slow if I run multiple instances of it in parallel. I wonder if it should be moved to sequential so that it does not compete for resources with other tests.

Vague benchmark: If I run 96 instances of this test simultaneously, it takes about 55 seconds to complete. If I run 96 instances of test-fs-readfile-empty.js simultaneously, it takes 2 seconds. test-fs-readfile-error.js: 7 seconds. test-fs-readfile-fd.js: 2 seconds.

@Trott
Copy link
Member

Trott commented Jan 11, 2017

Test fails reliably in CI if 32 instances are run at once. (Might not even need that many.) https://ci.nodejs.org/job/node-stress-single-test/1101/nodes=osx1010/console

Same job moved to sequential is reliable: https://ci.nodejs.org/job/node-stress-single-test/1102/nodes=osx1010/console

Will submit a PR to move it.

Trott added a commit to Trott/io.js that referenced this issue Jan 11, 2017
@Trott
test: move resource intensive test to sequential
4abe302 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

Fixes: nodejs#10742
@Trott Trott mentioned this issue Jan 11, 2017
Closed
2 tasks
@Trott Trott closed this as completed in d3eca02 Jan 12, 2017
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 18, 2017
@Trott @italoacasas
test: move resource intensive test to sequential
48c320a 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 23, 2017
@Trott @italoacasas
test: move resource intensive test to sequential
2199033 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 25, 2017
@Trott @italoacasas
test: move resource intensive test to sequential
ab1b709 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 27, 2017
@Trott @italoacasas
test: move resource intensive test to sequential
30926ac 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 8, 2017
@Trott @MylesBorins
test: move resource intensive test to sequential
4e1642f 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: #10744
Fixes: #10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 9, 2017
@Trott @MylesBorins
test: move resource intensive test to sequential
5d0cc61 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: #10744
Fixes: #10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@refack
Copy link
Contributor

refack commented Oct 29, 2017

Flake is back (even in sequential) - https://ci.nodejs.org/job/node-test-commit-osx/13607/nodes=osx1010/console

@refack refack reopened this Oct 29, 2017
@refack refack added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 29, 2017
@Trott
Copy link
Member

Trott commented Oct 30, 2017

@refack Can you open a separate issue for things like this where the new failure is different (and likely unrelated) to the issue reported previously? The issue reported here is a timeout. The test was taking more than 60 seconds to run. The one you link to ls a different kind of failure and is very unlikely to be related.

@Trott Trott closed this as completed Oct 30, 2017
@Trott
Copy link
Member

Trott commented Oct 30, 2017

(I opened it as #16601.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: move resource intensive test to sequential Trott/io.js
3 participants
@mscdex @refack @Trott