Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: export URLSearchParams alongside URL #10761

Closed
jasnell opened this issue Jan 12, 2017 · 9 comments
Closed

url: export URLSearchParams alongside URL #10761

jasnell opened this issue Jan 12, 2017 · 9 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@jasnell
Copy link
Member

jasnell commented Jan 12, 2017

The URLSearchParams object is useful on it's own. Browsers allow it to be created and used independently, so should we.

Refs: #10454

@jasnell jasnell added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 12, 2017
@TimothyGu
Copy link
Member

This is done in #10399, though I can split out the specific change if needed.

TimothyGu added a commit to TimothyGu/node that referenced this issue Jan 14, 2017
@TimothyGu
Copy link
Member

Done in #10801.

@joyeecheung
Copy link
Member

@targos @TimothyGu This commit doesn't seem to to have the necessary metadata in the commit message?

326e967

@targos
Copy link
Member

targos commented Jan 22, 2017

Oh I didn't mean to push this commit. This was a mistake.
@nodejs/ctc the 10 minutes to force push are long gone but can we still remove it?

@joyeecheung joyeecheung reopened this Jan 23, 2017
@joyeecheung
Copy link
Member

Maybe just revert and reland it?

@targos
Copy link
Member

targos commented Jan 23, 2017

I guess that harm is done anyway (regarding tooling). I added the metadata as a comment in the commit.

@targos targos closed this as completed Jan 23, 2017
@jasnell
Copy link
Member Author

jasnell commented Jan 23, 2017

@joyeecheung the way we handle it is within the first ten minutes after a commit, and only if no other commits have landed since, a commit can be edited or amended to fix metadata with a force push. That is the only window of time given to correct a commit without requiring a full revert pr that would go through the normal review process.

@joyeecheung
Copy link
Member

@jasnell What I meant was a revert PR followed by a reland PR though. The release team has been notified via IRC so I think it's OK to leave it as-is.

@jasnell
Copy link
Member Author

jasnell commented Jan 23, 2017

It's typically not worth the additional clutter that would cause simply to update the metadata :-)

italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 25, 2017
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 27, 2017
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 30, 2017
italoacasas pushed a commit to italoacasas/node that referenced this issue Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

No branches or pull requests

4 participants