-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: export URLSearchParams alongside URL #10761
Comments
This is done in #10399, though I can split out the specific change if needed. |
Done in #10801. |
@targos @TimothyGu This commit doesn't seem to to have the necessary metadata in the commit message? |
Oh I didn't mean to push this commit. This was a mistake. |
Maybe just revert and reland it? |
I guess that harm is done anyway (regarding tooling). I added the metadata as a comment in the commit. |
@joyeecheung the way we handle it is within the first ten minutes after a commit, and only if no other commits have landed since, a commit can be edited or amended to fix metadata with a force push. That is the only window of time given to correct a commit without requiring a full revert pr that would go through the normal review process. |
@jasnell What I meant was a revert PR followed by a reland PR though. The release team has been notified via IRC so I think it's OK to leave it as-is. |
It's typically not worth the additional clutter that would cause simply to update the metadata :-) |
The
URLSearchParams
object is useful on it's own. Browsers allow it to be created and used independently, so should we.Refs: #10454
The text was updated successfully, but these errors were encountered: