Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this[searchParams].push is not a function #11101

Closed
stevenvachon opened this issue Feb 1, 2017 · 3 comments
Closed

this[searchParams].push is not a function #11101

stevenvachon opened this issue Feb 1, 2017 · 3 comments
Labels
confirmed-bug Issues with confirmed bugs. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@stevenvachon
Copy link

stevenvachon commented Feb 1, 2017

const url = new (require("url").URL)("http://domain/?var=");
console.log(url.searchParams);
url.search = "";  // critical step
console.log(url.searchParams);
url.searchParams.append("asdf", "asdf");
console.log(url.searchParams);
TypeError: this[searchParams].push is not a function
    at URLSearchParams.append (internal/url.js:737:24)
    at repl:1:148
    at ContextifyScript.Script.runInThisContext (vm.js:23:33)
    at REPLServer.defaultEval (repl.js:340:29)
    at bound (domain.js:280:14)
    at REPLServer.runBound [as eval] (domain.js:293:12)
    at REPLServer.onLine (repl.js:537:10)
    at emitOne (events.js:101:20)
    at REPLServer.emit (events.js:189:7)
    at REPLServer.Interface._onLine (readline.js:238:10)

This is a regression introduced in Node v7.5, as v7.4 doesn't have this issue.

@targos targos self-assigned this Feb 1, 2017
@targos targos added confirmed-bug Issues with confirmed bugs. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 1, 2017
@joyeecheung
Copy link
Member

Moved them around in the project because my mouse have gone carzy :/. Sorry

TimothyGu added a commit to TimothyGu/node that referenced this issue Feb 1, 2017
Fixes: nodejs#11101
Fixes: 98bb65f "url: improving URLSearchParams"
@TimothyGu
Copy link
Member

@targos, I went ahead and created #11105. Hope I didn't step on your toes or anything…

@targos targos removed their assignment Feb 1, 2017
@targos
Copy link
Member

targos commented Feb 1, 2017

@TimothyGu no problem. Thanks for doing it!

italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 4, 2017
PR-URL: nodejs#11105
Fixes: nodejs#11101
Fixes: 98bb65f "url: improving URLSearchParams"
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 14, 2017
PR-URL: nodejs#11105
Fixes: nodejs#11101
Fixes: 98bb65f "url: improving URLSearchParams"
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
krydos pushed a commit to krydos/node that referenced this issue Feb 25, 2017
PR-URL: nodejs#11105
Fixes: nodejs#11101
Fixes: 98bb65f "url: improving URLSearchParams"
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants