Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect link to style guide inside CONTRIBUTING.md #11456

Closed
wilkoklak opened this issue Feb 18, 2017 · 6 comments
Closed

Incorrect link to style guide inside CONTRIBUTING.md #11456

wilkoklak opened this issue Feb 18, 2017 · 6 comments
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Comments

@wilkoklak
Copy link

wilkoklak commented Feb 18, 2017 •
edited
Loading

  • Version:
  • Platform:
  • Subsystem:

Link to style guide in CONTRIBUTING.md is incorrect.

It should be doc/STYLE-GUIDE.md, not doc/STYLE_GUIDE.md
@mscdex mscdex added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Feb 18, 2017
@cjihrig
Copy link
Contributor

cjihrig commented Feb 18, 2017

Care to open a PR to fix it?

@wilkoklak
Copy link
Author

I will do it tommorow, it's late for me and I'm too lazy now :P
If no one does it by tommorow, I'll do it then :)

@Dean-Coakley
Copy link
Contributor

Dean-Coakley commented Feb 19, 2017 •
edited
Loading

Fixed! Thanks for reporting this issue!

@a4479af70e9bd06e562ed4d22d1e66d3286f854b

@gibfahn
Copy link
Member

gibfahn commented Feb 20, 2017

PR to fix raised in #11460

@Dean-Coakley Dean-Coakley mentioned this issue Feb 20, 2017
Closed
@wilkoklak
Copy link
Author

Wow, sorry for the trouble, I should've asked first if that was link or filename supposed to change. I also had little time and I'm not so git-fluent so I would make even more troubles if I fixed that myself.

@gibfahn
Copy link
Member

gibfahn commented Feb 21, 2017

@wilkoklak I don't think you caused any trouble at all. Raising an issue is great, you don't need to raise a PR if you don't want to. Thanks for pointing (my mistake) out!

Dean-Coakley added a commit to Dean-Coakley/node that referenced this issue Feb 21, 2017
@Dean-Coakley
doc: change STYLE-GUIDE to STYLE_GUIDE
115a20c 
Fixes: nodejs#11456
addaleax pushed a commit that referenced this issue Feb 22, 2017
@Dean-Coakley @addaleax
doc: change STYLE-GUIDE to STYLE_GUIDE
d301367 
PR-URL: #11460
Fixes: #11456
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell pushed a commit that referenced this issue Mar 7, 2017
@Dean-Coakley @jasnell
doc: change STYLE-GUIDE to STYLE_GUIDE
7fce8f8 
PR-URL: #11460
Fixes: #11456
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell pushed a commit that referenced this issue Mar 7, 2017
@Dean-Coakley @jasnell
doc: change STYLE-GUIDE to STYLE_GUIDE
5398b09 
PR-URL: #11460
Fixes: #11456
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue Mar 9, 2017
@Dean-Coakley @MylesBorins
doc: change STYLE-GUIDE to STYLE_GUIDE
42304de 
PR-URL: #11460
Fixes: #11456
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue Mar 9, 2017
@Dean-Coakley @MylesBorins
doc: change STYLE-GUIDE to STYLE_GUIDE
485ec6c 
PR-URL: #11460
Fixes: #11456
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mscdex @cjihrig @Dean-Coakley @gibfahn @wilkoklak