Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fg(1) in readline's page is broken link #11492

Closed
hiroppy opened this issue Feb 22, 2017 · 1 comment
Closed

fg(1) in readline's page is broken link #11492

hiroppy opened this issue Feb 22, 2017 · 1 comment
Labels
doc Issues and PRs related to the documentations.

Comments

@hiroppy
Copy link
Member

hiroppy commented Feb 22, 2017 •
edited
Loading

  • Version: N/A
  • Platform: N/A
  • Subsystem: doc

This page is 404 now.

disputed point: https://nodejs.org/dist/latest-v7.x/docs/api/readline.html#readline_event_sigcont
@hiroppy hiroppy added the doc Issues and PRs related to the documentations. label Feb 22, 2017
@mscdex mscdex added the good first issue Issues that are suitable for first-time contributors. label Feb 22, 2017
@Fishrock123
Copy link
Contributor

See #11504

karanjthakkar added a commit to karanjthakkar/node that referenced this issue Feb 22, 2017
@karanjthakkar
docs: Change broken fg(1) links to fg(1p)
c0429d1 
The fg(1) links in the readline docs have moved
from `http://man7.org/linux/man-pages/man1/fg.1.html`
to `http://man7.org/linux/man-pages/man1/fg.1p.html`.
It also modifies the regex for replacing man page links
in docs by allowing optional character after number.
eg: fg(1) and fg(1p) will both be now parsed and replaced.

Fixes: nodejs#11492
@addaleax addaleax removed the good first issue Issues that are suitable for first-time contributors. label Feb 22, 2017
addaleax pushed a commit that referenced this issue Feb 24, 2017
@karanjthakkar @addaleax
doc: change broken fg(1) links to fg(1p)
47034e1 
The fg(1) links in the readline docs have moved
from `http://man7.org/linux/man-pages/man1/fg.1.html`
to `http://man7.org/linux/man-pages/man1/fg.1p.html`.
It also modifies the regex for replacing man page links
in docs by allowing optional character after number.
eg: fg(1) and fg(1p) will both be now parsed and replaced.

Fixes: #11492
PR-URL: #11504
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @addaleax @Fishrock123 @hiroppy