Add vcbuild cpplint and and update CONTRIBUTING.md
#11816
Labels
build
Issues and PRs related to build files or the CI.
good first issue
Issues that are suitable for first-time contributors.
windows
Issues and PRs related to the Windows platform.
Comments
gibfahn
added
good first issue
|
I would like to give a try on this -P |
|
@liusy182 Great, go for it! If you have any issues let us know. |
liusy182
pushed a commit
to liusy182/node
that referenced
this issue
Mar 15, 2017
This PR adds cpp linting to windows build script. After this change, running command `vcbuild lint` will run both cpp linting and javascript linting on a windows machine. Fixes: nodejs#11816
4 tasks
italoacasas
pushed a commit
to italoacasas/node
that referenced
this issue
Mar 20, 2017
This PR adds cpp linting to windows build script. After this change, running command `vcbuild lint` will run both cpp linting and javascript linting on a windows machine. PR-URL: nodejs#11856 Fixes: nodejs#11816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jungx098
pushed a commit
to jungx098/node
that referenced
this issue
Mar 21, 2017
This PR adds cpp linting to windows build script. After this change, running command `vcbuild lint` will run both cpp linting and javascript linting on a windows machine. PR-URL: nodejs#11856 Fixes: nodejs#11816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
kfarnung
pushed a commit
to kfarnung/node
that referenced
this issue
Aug 16, 2017
This PR adds cpp linting to windows build script. After this change, running command `vcbuild lint` will run both cpp linting and javascript linting on a windows machine. PR-URL: nodejs#11856 Fixes: nodejs#11816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this issue
Sep 19, 2017
This PR adds cpp linting to windows build script. After this change, running command `vcbuild lint` will run both cpp linting and javascript linting on a windows machine. Backport-PR-URL: #14879 PR-URL: #11856 Fixes: #11816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Implement
cpplintforvcbuild.bat(i.e. a windows version of the equivalent Makefile target). Thenlintcan be implemented asjslintandcpplint.See #11151 (comment).
The line in #11151 can then be updated to reflect this addition (i.e. suggest that people use
vcbuild lint).Optimistically marking this as a
good first contributionas it should be a self-contained bit of Windows syntax to runtools/cpplint.pyandtools/check-imports.py.If you'd like to have a go at this then please comment here to let other people know. You can follow the guide in
CONTRIBUTING.mdto submit a PR.The text was updated successfully, but these errors were encountered: