Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError is not documented #12274

Closed
targos opened this issue Apr 7, 2017 · 7 comments
Closed

AssertionError is not documented #12274

targos opened this issue Apr 7, 2017 · 7 comments
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@targos
Copy link
Member

targos commented Apr 7, 2017

AssertionError is exported by the assert module.
The documentation has many mentions to AssertionError but the value itself is not documented. I think it deserves a paragraph.

@targos targos added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Apr 7, 2017
@joyeecheung joyeecheung added the good first issue Issues that are suitable for first-time contributors. label Apr 10, 2017
@joyeecheung
Copy link
Member

Labeled as a good first contribution for now. We can remove it later if nobody opens a PR for it.

@shubheksha
Copy link
Contributor

Hey, I can help with this if given some pointers about what regarding AssertionError needs to be included. 😄

@addaleax
Copy link
Member

@shubheksha It should probably include AssertionError as a new heading, mention since when it is exported (let me know/ping me on IRC if you are not sure how to figure that out), and mention/explain its own properties (actual, expected, operator, and maybe generatedMessage).

@shubheksha
Copy link
Contributor

@addaleax, thanks for the info! Will it go as a heading in assert.md at the very top?

@addaleax
Copy link
Member

@shubheksha Either that, or at the very bottom (and as a ## heading, under the big # Assert one, in any case). The headings should be sorted alphabetically, but I’m not sure myself how to interpret that here. 😄

@joyeecheung
Copy link
Member

@shubheksha Or you can put it in errors.md and link to it from assert.md. The other way around works fine too, but I think the examples in errors.md would help you know what needs to be included :D

@addaleax
Copy link
Member

ping @shubheksha … is there anything we can help with? :)

daxlab pushed a commit to daxlab/node that referenced this issue Jul 16, 2017
addaleax pushed a commit that referenced this issue Aug 10, 2017
Fixes: #12274
PR-URL: #14261
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Development

No branches or pull requests

4 participants