Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora test failure: test-benchmark-crypto #12497

Closed
Fishrock123 opened this issue Apr 18, 2017 · 5 comments
Closed

fedora test failure: test-benchmark-crypto #12497

Fishrock123 opened this issue Apr 18, 2017 · 5 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests.

Comments

@Fishrock123
Copy link
Contributor

This failed against the unrelated #12490

in https://ci.nodejs.org/job/node-test-commit-linux/9201/nodes=fedora23/console

not ok 29 parallel/test-benchmark-crypto
  ---
  duration_ms: 2.329
  severity: fail
  stack: |-
    
    crypto/aes-gcm-throughput.js
    crypto/aes-gcm-throughput.js len=1 cipher="aes-128-gcm" n=1: 0.006952214115344836
    crypto/aes-gcm-throughput.js len=1 cipher="aes-192-gcm" n=1: 0.004117862541667656
    crypto/aes-gcm-throughput.js len=1 cipher="aes-256-gcm" n=1: 0.006152152078471565
    
    crypto/cipher-stream.js
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES192" writes=1: 7.300269507811883e-7
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES256" writes=1: 8.525659430594215e-7
    
    crypto/get-ciphers.js
    crypto/get-ciphers.js v="crypto" n=1: 185.0217150735896
    crypto/get-ciphers.js v="tls" n=1: 294.8083657180323
    
    crypto/hash-stream-creation.js
    crypto/hash-stream-creation.js api="stream" len=1 out="buffer" type="buf" algo="sha256" writes=1: 0.0000012189394019881118
    /home/iojs/build/workspace/node-test-commit-linux/nodes/fedora23/benchmark/run.js:62
          var rate = data.rate.toString().split('.');
                              ^
    
    TypeError: Cannot read property 'toString' of null
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora23/benchmark/run.js:62:27)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at process.nextTick (internal/child_process.js:753:12)
        at _combinedTickCallback (internal/process/next_tick.js:73:7)
        at process._tickCallback (internal/process/next_tick.js:104:9)
    
    assert.js:86
      throw new assert.AssertionError({
      ^
    AssertionError: 1 === 0
        at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora23/test/parallel/test-benchmark-crypto.js:34:10)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:196:12)

cc @Trott

@Fishrock123 Fishrock123 added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. labels Apr 18, 2017
@Trott
Copy link
Member

Trott commented Apr 19, 2017

@joyeecheung I don't suppose you got anywhere looking at #12433, did you? This issue would seem to suggest that it's a problem in run.js itself or something like that and not at all a problem in the http test double.

MylesBorins added a commit that referenced this issue May 2, 2017
Notable Changes:

* module:
  - The module loading global fallback to the Node executable's
    directory now works correctly on Windows.
    (Richard Lau) #9283
* src:
  - fix base64 decoding in rare edgecase
    (Nikolai Vavilov) #11995
* tls:
  - fix rare segmentation faults when using TLS
   * (Trevor Norris) #11947
   * (Ben Noordhuis) #11898
   * (jBarz) #11776

PR-URL: #12497
MylesBorins added a commit that referenced this issue May 2, 2017
MylesBorins added a commit that referenced this issue May 2, 2017
Notable Changes:

* module:
  - The module loading global fallback to the Node executable's
    directory now works correctly on Windows.
    (Richard Lau) #9283
* src:
  - fix base64 decoding in rare edgecase
    (Nikolai Vavilov) #11995
* tls:
  - fix rare segmentation faults when using TLS
   * (Trevor Norris) #11947
   * (Ben Noordhuis) #11898
   * (jBarz) #11776

PR-URL: #12497
imyller added a commit to imyller/meta-nodejs that referenced this issue May 2, 2017
    Notable Changes:

    * module:
      - The module loading global fallback to the Node executable's
        directory now works correctly on Windows.
        (Richard Lau) nodejs/node#9283
    * src:
      - fix base64 decoding in rare edgecase
        (Nikolai Vavilov) nodejs/node#11995
    * tls:
      - fix rare segmentation faults when using TLS
       * (Trevor Norris) nodejs/node#11947
       * (Ben Noordhuis) nodejs/node#11898
       * (jBarz) nodejs/node#11776

    PR-URL: nodejs/node#12497

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this issue May 2, 2017
    Notable Changes:

    * module:
      - The module loading global fallback to the Node executable's
        directory now works correctly on Windows.
        (Richard Lau) nodejs/node#9283
    * src:
      - fix base64 decoding in rare edgecase
        (Nikolai Vavilov) nodejs/node#11995
    * tls:
      - fix rare segmentation faults when using TLS
       * (Trevor Norris) nodejs/node#11947
       * (Ben Noordhuis) nodejs/node#11898
       * (jBarz) nodejs/node#11776

    PR-URL: nodejs/node#12497

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
anchnk pushed a commit to anchnk/node that referenced this issue May 6, 2017
Notable Changes:

* module:
  - The module loading global fallback to the Node executable's
    directory now works correctly on Windows.
    (Richard Lau) nodejs#9283
* src:
  - fix base64 decoding in rare edgecase
    (Nikolai Vavilov) nodejs#11995
* tls:
  - fix rare segmentation faults when using TLS
   * (Trevor Norris) nodejs#11947
   * (Ben Noordhuis) nodejs#11898
   * (jBarz) nodejs#11776

PR-URL: nodejs#12497
@Trott
Copy link
Member

Trott commented May 9, 2017

Failed again today:

https://ci.nodejs.org/job/node-test-commit-linux/9736/nodes=fedora22/console

not ok 28 parallel/test-benchmark-crypto
  ---
  duration_ms: 3.471
  severity: fail
  stack: |-
    
    crypto/aes-gcm-throughput.js
    crypto/aes-gcm-throughput.js len=1 cipher="aes-128-gcm" n=1: 0.007032983467259463
    crypto/aes-gcm-throughput.js len=1 cipher="aes-192-gcm" n=1: 0.007420370125193427
    crypto/aes-gcm-throughput.js len=1 cipher="aes-256-gcm" n=1: 0.007760184683912663
    
    crypto/cipher-stream.js
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES192" writes=1: 8.224968813154231e-7
    crypto/cipher-stream.js api="stream" len=1 type="buf" cipher="AES256" writes=1: 7.647466927204793e-7
    
    crypto/get-ciphers.js
    crypto/get-ciphers.js v="crypto" n=1: 250.8312547783354
    crypto/get-ciphers.js v="tls" n=1: 212.13420373411353
    
    crypto/hash-stream-creation.js
    crypto/hash-stream-creation.js api="stream" len=1 out="buffer" type="buf" algo="sha256" writes=1: 0.0000012591816931824305
    crypto/hash-stream-creation.js api="stream" len=1 out="buffer" type="buf" algo="md5" writes=1: 8.06266245477559e-7
    
    crypto/hash-stream-throughput.js
    crypto/hash-stream-throughput.js api="stream" len=1 type="buf" algo="sha1" writes=1: 0.0000012913913886547416
    crypto/hash-stream-throughput.js api="stream" len=1 type="buf" algo="sha256" writes=1: 8.427605549710038e-7
    /home/iojs/build/workspace/node-test-commit-linux/nodes/fedora22/benchmark/run.js:62
          var rate = data.rate.toString().split('.');
                              ^
    
    TypeError: Cannot read property 'toString' of null
        at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora22/benchmark/run.js:62:27)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at process.nextTick (internal/child_process.js:755:12)
        at _combinedTickCallback (internal/process/next_tick.js:74:7)
        at process._tickCallback (internal/process/next_tick.js:105:9)
    assert.js:92
      throw new AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 1 === 0
        at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora22/test/parallel/test-benchmark-crypto.js:34:10)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:197:12)

@Trott
Copy link
Member

Trott commented May 9, 2017

The null probably originates as NaN and gets stringified when process.send() is called, resulting in null. /cc @joyeecheung

EDIT: Oh, or perhaps more likely, Infinity instead of NaN.

Trott added a commit to Trott/io.js that referenced this issue May 9, 2017
Some benchmark tests are failing intermittently, possibly due to
hrtime() imprecision on particular hosts. This change will confirm or
refute that as the root cause the next time the test fails on CI. Either
way, it's a valid check.

Refs: nodejs#12497
Refs: nodejs#12433
@joyeecheung
Copy link
Member

@Trott I got stuck because I didn't think of the NaN/Infinity -> null thing..thanks for figuring this one out!

Trott added a commit to Trott/io.js that referenced this issue May 11, 2017
Some benchmark tests are failing intermittently, possibly due to
hrtime() imprecision on particular hosts. This change will confirm or
refute that as the root cause the next time the test fails on CI. Either
way, it's a valid check.

PR-URL: nodejs#12934
Ref: nodejs#12497
Ref: nodejs#12433
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
Some benchmark tests are failing intermittently, possibly due to
hrtime() imprecision on particular hosts. This change will confirm or
refute that as the root cause the next time the test fails on CI. Either
way, it's a valid check.

PR-URL: nodejs#12934
Ref: nodejs#12497
Ref: nodejs#12433
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
Notable Changes:

* module:
  - The module loading global fallback to the Node executable's
    directory now works correctly on Windows.
    (Richard Lau) nodejs/node#9283
* src:
  - fix base64 decoding in rare edgecase
    (Nikolai Vavilov) nodejs/node#11995
* tls:
  - fix rare segmentation faults when using TLS
   * (Trevor Norris) nodejs/node#11947
   * (Ben Noordhuis) nodejs/node#11898
   * (jBarz) nodejs/node#11776

PR-URL: nodejs/node#12497
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
@Trott
Copy link
Member

Trott commented Aug 13, 2017

This has been resolved since (I think) May. Closing.

@Trott Trott closed this as completed Aug 13, 2017
BridgeAR pushed a commit that referenced this issue Sep 22, 2017
The message sent using process.send() goes through JSON
serialization and parsing, which could lead to surprising behaviors.
This commit elaborate a bit more on this and add a link to
the notes about these caveats in the ECMAScript specification.

PR-URL: #12963
Refs: #12497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 23, 2017
The message sent using process.send() goes through JSON
serialization and parsing, which could lead to surprising behaviors.
This commit elaborate a bit more on this and add a link to
the notes about these caveats in the ECMAScript specification.

PR-URL: nodejs/node#12963
Refs: nodejs/node#12497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this issue Sep 25, 2017
The message sent using process.send() goes through JSON
serialization and parsing, which could lead to surprising behaviors.
This commit elaborate a bit more on this and add a link to
the notes about these caveats in the ECMAScript specification.

PR-URL: #12963
Refs: #12497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this issue Sep 29, 2017
The message sent using process.send() goes through JSON
serialization and parsing, which could lead to surprising behaviors.
This commit elaborate a bit more on this and add a link to
the notes about these caveats in the ECMAScript specification.

PR-URL: #12963
Refs: #12497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants