Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix/rename test/debugger/helper-debugger-* #12742

Closed
6 tasks
refack opened this issue Apr 29, 2017 · 6 comments · May be fixed by aliscco/alisco-node#279
Closed
6 tasks

test: fix/rename test/debugger/helper-debugger-* #12742

refack opened this issue Apr 29, 2017 · 6 comments · May be fixed by aliscco/alisco-node#279
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Comments

@refack
Copy link
Contributor

refack commented Apr 29, 2017 •
edited
Loading

  • Version: master
  • Subsystem: test

tests for line debugger should use inspect protocol and CLI args

Tracking:

  • test/debugger/test-debugger-repl-break-in-module.js
  • test/debugger/test-debugger-repl-restart.js
  • test/debugger/test-debugger-repl-term.js
  • test/debugger/test-debugger-repl-utf8.js
  • test/debugger/helper-debugger-repl.js
  • test/debugger/test-debugger-repl.js
@vsemozhetbyt vsemozhetbyt added debugger inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Apr 29, 2017
@Trott
Copy link
Member

Trott commented May 27, 2017

These tests aren't run in CI or via make test/vcbuild test. They should probably be moved one-by-one to parallel or sequential if they work there, and ones that are truly debugger-specific should be removed. They have a very checkered history in terms of reliability.

@refack refack self-assigned this May 27, 2017
@refack refack added the good first issue Issues that are suitable for first-time contributors. label May 28, 2017
@refack
Copy link
Contributor Author

refack commented May 28, 2017

To follow up on @Trott suggestion I've made a tracking list. Marking as good-first-contribution but I assume contributors will need mentoring. I'll be happy to help.

@rhoboat
Copy link

rhoboat commented May 28, 2017

dibs

@refack refack removed the good first issue Issues that are suitable for first-time contributors. label May 28, 2017
@refack
Copy link
Contributor Author

refack commented May 28, 2017

@archanid as I said, hopefully it's well defined, but it might require some trial and error. If you need any help feel free to ping me.

@refack refack assigned refack and unassigned refack May 28, 2017
@rhoboat rhoboat mentioned this issue May 28, 2017
Closed
9 tasks
@refack refack added the wip Issues and PRs that are still a work in progress. label Jun 15, 2017
@refack refack mentioned this issue Jun 15, 2017
Closed
@maclover7
Copy link
Contributor

@refack @Trott should this be closed since #15139 was merged / test/debugger has been deleted?

@refack refack removed the wip Issues and PRs that are still a work in progress. label Oct 14, 2017
@refack
Copy link
Contributor Author

refack commented Oct 14, 2017

@archanid I'm closing this. If by any chance you found some good nuggets in that directory, feel free to PR them back.

@refack refack closed this as completed Oct 14, 2017
@refack refack removed their assignment Oct 12, 2018
@aliscco aliscco mentioned this issue Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 30 vulnerabilities aliscco/alisco-node
5 participants
@refack @Trott @maclover7 @vsemozhetbyt @rhoboat